From 4d66b4de053ad3c2cdafa89d4ec2e682a09309bc Mon Sep 17 00:00:00 2001 From: Paul Armstrong Date: Tue, 6 Feb 2024 08:40:18 -0800 Subject: [PATCH] fix: ensure ParentProps is declared as a type import Fixes #1311 --- .changeset/many-eggs-move.md | 5 +++++ packages/start/shared/ErrorBoundary.tsx | 17 +++-------------- 2 files changed, 8 insertions(+), 14 deletions(-) create mode 100644 .changeset/many-eggs-move.md diff --git a/.changeset/many-eggs-move.md b/.changeset/many-eggs-move.md new file mode 100644 index 000000000..81448e0e0 --- /dev/null +++ b/.changeset/many-eggs-move.md @@ -0,0 +1,5 @@ +--- +"@solidjs/start": patch +--- + +Fixed an issue with TypeScript based projects throwing client side errors regarding a type input in the `ErrorBoundary`.wq diff --git a/packages/start/shared/ErrorBoundary.tsx b/packages/start/shared/ErrorBoundary.tsx index 3743e32cf..d150cfe91 100644 --- a/packages/start/shared/ErrorBoundary.tsx +++ b/packages/start/shared/ErrorBoundary.tsx @@ -1,24 +1,13 @@ -import { - ErrorBoundary as DefaultErrorBoundary, - ParentProps, -} from "solid-js"; +import { ErrorBoundary as DefaultErrorBoundary, type ParentProps } from "solid-js"; import { HttpStatusCode } from "./HttpStatusCode"; import { DevOverlay } from "./dev-overlay"; export function ErrorBoundary(props: ParentProps) { if (import.meta.env.DEV) { - return ( - - {props.children} - - ); + return {props.children}; } return ( - - )} - > + }> {props.children} );