Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text that looks like a heading must be coded as a heading #65

Closed
6 tasks done
ecureuill opened this issue Apr 9, 2020 · 4 comments
Closed
6 tasks done

Text that looks like a heading must be coded as a heading #65

ecureuill opened this issue Apr 9, 2020 · 4 comments
Assignees
@caroltaus @EduKobaiashi @CAndresH
Labels
🐛bug Something isn't working env:development Something isn't working on dev P3 - Normal May be fixed after the release / in the next release. This is the priority set as default. passed 🔵 The implementation meets the requirement resolution::shipit:Fixed role:Student user's role S2 - Minor Defects Causes the system to show incorrect, incomplete, or inconsistent results type:a11y Accessibility related functionality is broken type:usability
Milestone
EPIC a11y Adaptable

Comments

@ecureuill
Copy link
Collaborator

ecureuill commented Apr 9, 2020 •
edited by CAndresH
Loading

Expected Behavior

An element coded as a heading must function as a heading.

Current Behavior

  • Home page
    image
  • SELI Coures page
    image
  • Subscribed courses page
    image
  • Course page
    image
  • Course's content page (every accordion)
    image
  • Quiz
    image

Steps to Reproduce

  1. Navigate through SELI platform
    1. For each element that looks like a heading, check if it's coded as a heading

Possible Implementation

Follows #62 and #63 specifications about headings
Follows #58 specifications about accordions

Heading tags in orange on each image above are suggestions, you are free to code the level hierarchy

Related issues

#64
@ecureuill ecureuill added 🐛bug Something isn't working type:a11y Accessibility related functionality is broken role:Student user's role env:development Something isn't working on dev P3 - Normal May be fixed after the release / in the next release. This is the priority set as default. S2 - Minor Defects Causes the system to show incorrect, incomplete, or inconsistent results type:usability labels Apr 9, 2020
@ecureuill ecureuill added this to the EPIC a11y Adaptable milestone Apr 9, 2020
@ecureuill ecureuill mentioned this issue Apr 13, 2020
Open
@solex2006 solex2006 added the 2 - Ready Feature ready to implement label Apr 14, 2020
@github-actions
Copy link

This Feature is ready to be implemented.

@solex2006 solex2006 added 3 - Working Development in progress and removed 2 - Ready Feature ready to implement labels Apr 14, 2020
CAndresH added a commit that referenced this issue Apr 15, 2020
@CAndresH
Text that looks like a heading must be coded as a heading #65
8dba45c
@CAndresH CAndresH self-assigned this Apr 15, 2020
@CAndresH CAndresH added need tester Ready for test and removed 3 - Working Development in progress labels Apr 15, 2020
@github-actions
Copy link

This feature have been implemented and is ready for Funcional Test.
Please, test the feature.

@solex2006 solex2006 added passed 🔵 The implementation meets the requirement and removed need tester Ready for test labels Apr 18, 2020
@solex2006 solex2006 added the 4 - In Review Solution in test or pr label Apr 18, 2020
@github-actions
Copy link

Functional Test passed!
Please, make a PULL REQUEST.

@solex2006 solex2006 removed the 4 - In Review Solution in test or pr label Apr 18, 2020
@ecureuill ecureuill added resolution::shipit:Fixed and removed passed 🔵 The implementation meets the requirement labels Jun 20, 2020
@solex2006 solex2006 added the passed 🔵 The implementation meets the requirement label Jun 20, 2020
@github-actions
Copy link

Functional Test passed!
Please, make a PULL REQUEST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caroltaus caroltaus

@EduKobaiashi EduKobaiashi

@CAndresH CAndresH

Labels
🐛bug Something isn't working env:development Something isn't working on dev P3 - Normal May be fixed after the release / in the next release. This is the priority set as default. passed 🔵 The implementation meets the requirement resolution::shipit:Fixed role:Student user's role S2 - Minor Defects Causes the system to show incorrect, incomplete, or inconsistent results type:a11y Accessibility related functionality is broken type:usability
Projects
None yet
Milestone
EPIC a11y Adaptable
Development

No branches or pull requests
5 participants
@ecureuill @solex2006 @caroltaus @EduKobaiashi @CAndresH