From 2e3107db26e011f428e998d5326e549c12f3c224 Mon Sep 17 00:00:00 2001
From: SpacialCircumstances <SpacialCircumstances@users.noreply.github.com>
Date: Sat, 6 Jul 2024 01:23:29 +0200
Subject: [PATCH] Validate that waypoint source is carrier location when
 setting waypoints for orbiting carrier

---
 server/services/waypoint.ts | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/server/services/waypoint.ts b/server/services/waypoint.ts
index 00703b870..47c538ff5 100644
--- a/server/services/waypoint.ts
+++ b/server/services/waypoint.ts
@@ -52,7 +52,7 @@ export default class WaypointService {
     }
 
     async saveWaypoints(game: Game, player: Player, carrierId: DBObjectId, waypoints: CarrierWaypointBase[], looped: boolean) {
-        let carrier = this.carrierService.getById(game, carrierId);
+        const carrier = this.carrierService.getById(game, carrierId);
 
         if (!carrier) {
             throw new ValidationError(`Could not find carrier with id ${carrierId}`);
@@ -61,8 +61,8 @@ export default class WaypointService {
         return await this.saveWaypointsForCarrier(game, player, carrier, waypoints, looped);
     }
 
-    async saveWaypointsForCarrier(game: Game, player: Player, carrier: Carrier, waypoints: CarrierWaypointBase[], looped: boolean, writeToDB: boolean = true) {
-        if (looped == null) {
+    async saveWaypointsForCarrier(game: Game, player: Player, carrier: Carrier, waypoints: CarrierWaypointBase[], looped: boolean | null, writeToDB: boolean = true) {
+        if (looped === null) {
             looped = false;
         }
         
@@ -81,8 +81,8 @@ export default class WaypointService {
         // If the carrier is currently in transit then double check that the first waypoint
         // matches the source and destination.
         if (!carrier.orbiting) {
-            let currentWaypoint = carrier.waypoints[0];
-            let newFirstWaypoint = waypoints[0];
+            const currentWaypoint = carrier.waypoints[0];
+            const newFirstWaypoint = waypoints[0];
 
             if (!newFirstWaypoint 
                 || currentWaypoint.source.toString() !== newFirstWaypoint.source.toString()
@@ -93,16 +93,20 @@ export default class WaypointService {
             if (+newFirstWaypoint.delayTicks) {
                 throw new ValidationError('The first waypoint cannot have delay ticks if mid-flight.');
             }
+        } else {
+            if (carrier.orbiting.toString() !== waypoints[0].source.toString()) {
+                throw new ValidationError('The source star does not match the carrier location.');
+            }
         }
 
         // Validate new waypoints.
         for (let i = 0; i < waypoints.length; i++) {
-            let waypoint = waypoints[i];
+            const waypoint = waypoints[i];
 
-            let sourceStar = this.starService.getById(game, waypoint.source);
-            let destinationStar = this.starService.getById(game, waypoint.destination);
+            const sourceStar = this.starService.getById(game, waypoint.source);
+            const destinationStar = this.starService.getById(game, waypoint.destination);
 
-            let sourceStarName = sourceStar == null ? 'Unknown' : sourceStar.name; // Could be travelling from a destroyed star.
+            const sourceStarName = sourceStar == null ? 'Unknown' : sourceStar.name; // Could be travelling from a destroyed star.
 
             // Make sure the user isn't being a dumbass.
             waypoint.actionShips = waypoint.actionShips || 0;
@@ -185,11 +189,11 @@ export default class WaypointService {
     }
 
     _waypointRouteIsWithinHyperspaceRange(game: Game, carrier: Carrier, waypoint: CarrierWaypointBase) {
-        let sourceStar = this.starService.getById(game, waypoint.source);
-        let destinationStar = this.starService.getById(game, waypoint.destination);
+        const sourceStar = this.starService.getById(game, waypoint.source);
+        const destinationStar = this.starService.getById(game, waypoint.destination);
 
         // Stars may have been destroyed.
-        if (sourceStar == null || destinationStar == null) {
+        if (!sourceStar || !destinationStar) {
             return false;
         }