Demote Arc<Bank> parameter to &Bank (#33130)

steviez · web-flow · commit 3b108564f9f6 · 2023-09-05T21:04:39.000+02:00
diff --git a/core/src/cache_block_meta_service.rs b/core/src/cache_block_meta_service.rs
@@ -41,7 +41,7 @@ impl CacheBlockMetaService {
                     }
                     Ok(bank) => {
                         let mut cache_block_meta_timer = Measure::start("cache_block_meta_timer");
-                        Self::cache_block_meta(bank, &blockstore);
+                        Self::cache_block_meta(&bank, &blockstore);
                         cache_block_meta_timer.stop();
                         if cache_block_meta_timer.as_ms() > CACHE_BLOCK_TIME_WARNING_MS {
                             warn!(
@@ -57,7 +57,7 @@ impl CacheBlockMetaService {
         Self { thread_hdl }
     }
 
-    fn cache_block_meta(bank: Arc<Bank>, blockstore: &Blockstore) {
+    fn cache_block_meta(bank: &Bank, blockstore: &Blockstore) {
         if let Err(e) = blockstore.cache_block_time(bank.slot(), bank.clock().unix_timestamp) {
             error!("cache_block_time failed: slot {:?} {:?}", bank.slot(), e);
         }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ impl CacheBlockMetaService {`
`41`	`41`	`}`
`42`	`42`	`Ok(bank) => {`
`43`	`43`	`let mut cache_block_meta_timer = Measure::start("cache_block_meta_timer");`
`44`		`- Self::cache_block_meta(bank, &blockstore);`
	`44`	`+ Self::cache_block_meta(&bank, &blockstore);`
`45`	`45`	`cache_block_meta_timer.stop();`
`46`	`46`	`if cache_block_meta_timer.as_ms() > CACHE_BLOCK_TIME_WARNING_MS {`
`47`	`47`	`warn!(`
`@@ -57,7 +57,7 @@ impl CacheBlockMetaService {`
`57`	`57`	`Self { thread_hdl }`
`58`	`58`	`}`
`59`	`59`
`60`		`- fn cache_block_meta(bank: Arc<Bank>, blockstore: &Blockstore) {`
	`60`	`+ fn cache_block_meta(bank: &Bank, blockstore: &Blockstore) {`
`61`	`61`	`if let Err(e) = blockstore.cache_block_time(bank.slot(), bank.clock().unix_timestamp) {`
`62`	`62`	`error!("cache_block_time failed: slot {:?} {:?}", bank.slot(), e);`
`63`	`63`	`}`