Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a deprecated status after 10 failed tests #9

Open
2 of 3 tasks
pvgenuchten opened this issue May 30, 2024 · 5 comments
Open
2 of 3 tasks

a deprecated status after 10 failed tests #9

pvgenuchten opened this issue May 30, 2024 · 5 comments
Assignees

Comments

@pvgenuchten
Copy link
Contributor

pvgenuchten commented May 30, 2024

If a resource continues to fail (10 tests), it could be excluded for subsequent tests, its status can be set to 'deprecated'

You think this is a good idea, to keep the service performant?

Definition of Done

  • Decisions on design, and management (e.g. integrate detecting fails and status updates) and monitoring (e.g. desired visualisation)
  • Implementation
  • Deployment as part of like liveliness checker
@vgole001
Copy link
Contributor

vgole001 commented Jun 19, 2024

It looks like a good idea to me.
Probably we can set the number of failures to be flexible since it is depended on how often the tests run.

Concering the implementation
we can update the database to keep track of cummulative failures of a particular url in order to set it as deprecated
Some failure codes that would be fair to take into consideration
4xx Client Error Codes: [400,401,403,404,405,409]
5xx Server Error Codes: [500, 501, 503, 504]

@vgole001 vgole001 self-assigned this Jun 19, 2024
@BerkvensNick BerkvensNick moved this from To Discuss to Discussed in Soilwise Sprint Refinement Jun 20, 2024
@vgole001
Copy link
Contributor

To add some other thoughts on this issue
Excluding a deprecated url from future checks although it offers efficiency by reducing the total URL's to check it prevents us from detecting weather a previously deprecated URL has become available again.
Over time fewer and fewer links potentially will be checked and important information may be lost, since we dont have the opportunity to check the status of a deprecated url that has been been started working again.
False positives can also occur due to temporary issues rather than actual URL failures setting the URL to be invalid and consecutively deprecated.

@BerkvensNick
Copy link

BerkvensNick commented Aug 1, 2024

@vgole001 has this already been "deployed as part of like liveliness checker"?

@vgole001
Copy link
Contributor

vgole001 commented Aug 1, 2024

Hi @BerkvensNick
Yes, it is implemented, however the newest version of it is not merged on main yet.
Waiting for @pvgenuchten to review it

@pvgenuchten
Copy link
Contributor Author

I will manage this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussed
Development

No branches or pull requests

3 participants