Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how do we manage timeout? #10

Open
3 tasks done
pvgenuchten opened this issue May 30, 2024 · 2 comments
Open
3 tasks done

how do we manage timeout? #10

pvgenuchten opened this issue May 30, 2024 · 2 comments
Assignees

Comments

@pvgenuchten
Copy link
Contributor

pvgenuchten commented May 30, 2024

is there a parameter to set the timeout period?
how is the aspect logged if a timeout is detected

Definition of Done

  • Decisions on timout strategy, logging
  • Implementation
  • Deployment as part of like liveliness checker
@vgole001
Copy link
Contributor

Linkchecker has a timeout parameter that is set in seconds. The default timeout is 60 seconds.
Do we have to change that parameter and what is a valid value to set?
The logged output is expected to be smth like this ConnectTimeout: HTTPSConnectionPool(host='www.google.com', port=81)
after running linkchecker on https://www.google.com:81/ and setting timeout=20 being on result column.

@pvgenuchten
Copy link
Contributor Author

pvgenuchten commented Jun 12, 2024

I would go for a smaller timeout, maybe 5 seconds, just to keep progress

logged output looks good

@vgole001 vgole001 self-assigned this Jun 12, 2024
@BerkvensNick BerkvensNick moved this from To Discuss to Discussed in Soilwise Sprint Refinement Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Discussed
Development

No branches or pull requests

2 participants