Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues found during manual testing of 0.8.0 at deRSE24 #244

Open
5 tasks done
poikilotherm opened this issue Mar 6, 2024 · 5 comments
Open
5 tasks done

Issues found during manual testing of 0.8.0 at deRSE24 #244

poikilotherm opened this issue Mar 6, 2024 · 5 comments
Assignees
Labels
bug Something isn't working de-RSE24 Issues that should be fixed till de-RSE24 (march) enhancement New feature or request

Comments

@poikilotherm
Copy link
Member

poikilotherm commented Mar 6, 2024

@poikilotherm poikilotherm added bug Something isn't working enhancement New feature or request de-RSE24 Issues that should be fixed till de-RSE24 (march) labels Mar 6, 2024
@poikilotherm
Copy link
Member Author

poikilotherm commented Mar 7, 2024

Version given as 1.0 in CFF is interpreted as floating point (YAML parser!) and will give an error at deposit because not a valid string. We need to do a hard cast to string for the version

@led02
Copy link
Member

led02 commented Aug 6, 2024

Logs and errors are now handled a bit saner... i.e., the errors are output to the log.error channel (which is by default printed on the console).

Still lot's of stuff to do that will be handled in different issues (i.e., #238).

@sdruskat
Copy link
Contributor

sdruskat commented Aug 12, 2024

During the workshop, it was also mentioned that hermes should support older Python versions (i.e., 3.8).

I'm strictly against this, seeing that EOLs are approaching fast.
3.8 will be unsupported from October 2024, 3.9 October 2025.

I'd argue that requiring 3.10 is actually feasible and shouldn't be changed.

I.e., whoever is working on the 3.8 backport (mentioned in the paper draft) should drop their pen IMHO.

@led02
Copy link
Member

led02 commented Aug 12, 2024

I think 3.8 was also required to support SOMESY

@sdruskat
Copy link
Contributor

I think 3.8 was also required to support SOMESY

True. I suggest asking somesy to update to 3.10 instead of supporting versions near the EOL. Or were there any (dependency-related) reasons for sticking with 3.8 (other than: a lot of people still use it)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working de-RSE24 Issues that should be fixed till de-RSE24 (march) enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants