Skip to content

Commit 0c7db4f

Browse files
Temporarily disable LedgerSigner tests (#1477)
* Skip `LedgerSigner` tests * Update skip reason * Remove unused import * Update directory while building docker Starknet ledger app
1 parent 8cb1ea5 commit 0c7db4f

File tree

2 files changed

+9
-20
lines changed

2 files changed

+9
-20
lines changed

.github/workflows/checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ jobs:
196196
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools
197197
options: --rm -v ${{ github.workspace }}:/apps
198198
run: |
199-
cd /apps/app-starknet
199+
cd /apps/app-starknet/starknet
200200
cargo clean
201201
cargo ledger build nanox
202202

starknet_py/tests/unit/signer/test_ledger_signer.py

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from sys import platform
2-
31
import pytest
42

53
from starknet_py.common import create_sierra_compiled_contract
@@ -20,11 +18,8 @@
2018
from starknet_py.tests.e2e.fixtures.misc import load_contract
2119

2220

23-
# TODO (#1425): Currently Ledger tests are skipped on Windows due to different Speculos setup.
24-
@pytest.mark.skipif(
25-
platform == "win32",
26-
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
27-
)
21+
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
22+
@pytest.mark.skip
2823
def test_init_with_invalid_derivation_path():
2924
with pytest.raises(ValueError, match="Empty derivation path"):
3025
LedgerSigner(derivation_path_str="", chain_id=StarknetChainId.SEPOLIA)
@@ -81,10 +76,8 @@ def test_init_with_invalid_derivation_path():
8176
),
8277
],
8378
)
84-
@pytest.mark.skipif(
85-
platform == "win32",
86-
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
87-
)
79+
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
80+
@pytest.mark.skip
8881
def test_sign_transaction(transaction):
8982
# docs: start
9083

@@ -104,10 +97,8 @@ def test_sign_transaction(transaction):
10497
assert all(i != 0 for i in signature)
10598

10699

107-
@pytest.mark.skipif(
108-
platform == "win32",
109-
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
110-
)
100+
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
101+
@pytest.mark.skip
111102
def test_create_account_with_ledger_signer():
112103
# pylint: disable=unused-variable
113104
signer = LedgerSigner(
@@ -141,10 +132,8 @@ async def _get_account_balance_strk(client: FullNodeClient, address: int):
141132

142133

143134
@pytest.mark.asyncio
144-
@pytest.mark.skipif(
145-
platform == "win32",
146-
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
147-
)
135+
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
136+
@pytest.mark.skip
148137
async def test_deploy_account_and_transfer(client):
149138
signer = LedgerSigner(
150139
derivation_path_str="m/2645'/1195502025'/1470455285'/0'/0'/0",

0 commit comments

Comments
 (0)