Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research custom allocators (jemalloc/mimalloc) if they could bring better performance #98

Open
mkaput opened this issue Dec 18, 2024 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@mkaput
Copy link
Member

mkaput commented Dec 18, 2024

@mkaput commented on 2.07.2024, 13:11:23:

It looks like jemalloc brought improvements to Rust Analyzer:

It would be awesome to verify that one of these two would also improve CairoLS. For this, we need a reproducible benchmark code, though.

@mkaput mkaput added the help wanted Extra attention is needed label Dec 18, 2024
@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mateusfigmelo commented on 17.10.2024, 01:27:15:

Could you plz give me some more crates like jemallocator, snmalloc, mimalloc and so on?
I need to pick global allocator crates as many as possible and select which allocator is the best for our project performance.

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mkaput commented on 17.10.2024, 10:38:48:

Hey! These three are the only popular choices I know of.

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mateusfigmelo commented on 17.10.2024, 17:29:08:

I built snmalloc as a global allocator in my project, and only I got errors with snmalloc.
The others did work as well. Do you know about the reason?

@github-project-automation github-project-automation bot moved this to Triage in CairoLS Dec 18, 2024
@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mkaput commented on 17.10.2024, 17:31:42:

No idea. What were the errors?

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mateusfigmelo commented on 17.10.2024, 17:57:14:

FROM lukemathwalker/cargo-chef:latest-rust-1 AS chef
WORKDIR /app

# Builds a cargo-chef plan
FROM chef AS planner
COPY . .
RUN cargo chef prepare --recipe-path recipe.json

FROM chef AS builder
COPY --from=planner /app/recipe.json recipe.json
...

It is a part of my Dockerfile.
I got errors with this part in snmalloc-sys.

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mkaput commented on 17.10.2024, 18:25:33:

out of thin air, I have no idea what might be wrong

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mateusfigmelo commented on 17.10.2024, 18:35:31:

image
That's it.

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mkaput commented on 17.10.2024, 19:11:24:

looks like you haven't installed cmake in your container

@mkaput
Copy link
Member Author

mkaput commented Dec 18, 2024

@mateusfigmelo commented on 17.10.2024, 20:23:02:

I added command to install cmake in docker container, and built again.
As a result, the error is diappeard.
😄

@mkaput mkaput moved this from Triage to Backlog in CairoLS Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Status: Backlog
Development

No branches or pull requests

1 participant