Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility layer for pims #7

Open
blakeNaccarato opened this issue May 12, 2023 · 0 comments
Open

Add compatibility layer for pims #7

blakeNaccarato opened this issue May 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@blakeNaccarato
Copy link
Member

The flat metadata structure in boilercine facilitates serialization to file formats that expect flat metadata, such as NetCDF. The CINE reader implementation of pims may be a suitable substitute for the implementation in pycine, but the metadata layout in the pims implementation is nested, and has snake_case attributes rather than PascalCase coming from the original CINE file header. I think this is one situation where maintaining the source case convention is helpful, and only case-switching any properties that are surfaced out of the full set of metadata.

Add a from_* classmethod to Header that maps a pims CINE object to the existing Header dataclass, or something similar. Remember to add pims as a requirement and modify documentation to recommend that as the default CINE vendor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant