Skip to content

Commit

Permalink
Nits
Browse files Browse the repository at this point in the history
  • Loading branch information
fcharras committed Jan 17, 2024
1 parent 6bcf4d0 commit bd78618
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions benchmarks/ridge/objective.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,7 @@ def evaluate_result(self, weights, intercept, n_iter, **solver_parameters):
if not (isinstance(n_iter, numbers.Number) or (n_iter is None)):
n_iter = set(n_iter)
if len(n_iter) > 1:
raise ValueError(
"In multitarget mode, the same number of iterations is expected "
"for all targets, to keep reports comparable."
)
n_iter = max(n_iter)
n_iter = n_iter.pop()

# NB: str for n_iter is a more practical type because it enables
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/ridge/solvers/scikit_learn.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def skip(self, **objective_dict):
)

if solver == "DefaultDense":
return True, "No support this solver parameter."
return True, "No support for this solver parameter."

return False, None

Expand Down
2 changes: 1 addition & 1 deletion benchmarks/ridge/solvers/scikit_learn_intelex.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def skip(self, **objective_dict):

if solver != "DefaultDense":
# TODO: investigate ?
return True, "DefaultDense is the only supported solver parameter."
return True, "The only supported solver parameter is DefaultDense."

return False, None

Expand Down

0 comments on commit bd78618

Please sign in to comment.