Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler under Ruby 3.4 no longer treats base64 as a default gem #35

Closed
postmodern opened this issue Feb 2, 2025 · 2 comments
Closed
Assignees
Milestone

Comments

@postmodern
Copy link
Contributor

postmodern commented Feb 2, 2025

Seeing some spec failures due to Bundler not allowing async-dns to require base64.

LoadError:
  cannot load such file -- base64
# ./vendor/bundle/ruby/3.4.0/gems/async-dns-1.3.0/lib/async/dns/message.rb:24:in '<top (required)>'
# ./vendor/bundle/ruby/3.4.0/gems/async-dns-1.3.0/lib/async/dns.rb:27:in 'Kernel#require_relative'
# ./vendor/bundle/ruby/3.4.0/gems/async-dns-1.3.0/lib/async/dns.rb:27:in '<top (required)>'
# ./lib/ronin/dns/proxy/server.rb:24:in '<top (required)>'

https://github.com/ronin-rb/ronin-dns-proxy/actions/runs/13103082741/job/36553753530

This is apparently due to some recent changes to downgrade the base64 library from a default stdlib library and to a bundled gem. I believe you will need to add base64 to the gemspec, so other gems that depend on async-dns do not have to do the same.

postmodern added a commit to postmodern/async-dns that referenced this issue Feb 3, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@postmodern postmodern changed the title Bundler under Ruby 3.4 no longer treats base64 as a default or bundled gem Bundler under Ruby 3.4 no longer treats base64 as a default gem Feb 3, 2025
@postmodern
Copy link
Contributor Author

See PR #36.

@ioquatix
Copy link
Member

ioquatix commented Feb 15, 2025

I apologise.

I have not maintained this code for a long time. The last release was in 2021.

I have been working on refactoring this code to drop Async::IO.

I would like to release this as v1.4.0 but there will be some minor breaking changes; mainly the logger interfaces and the IO handling.

This problem is already fixed/resolved on main.

I'll work on this tomorrow and cut a release. I'll document all breaking changes in releases.md.

@ioquatix ioquatix self-assigned this Feb 15, 2025
@ioquatix ioquatix added this to the v1.4.0 milestone Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants