Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website Feature]: small newsletter subscription page improvements #879

Open
2 of 5 tasks
ssandino opened this issue Aug 2, 2024 · 3 comments
Open
2 of 5 tasks
Assignees
Labels
feature New feature or request website Issues concerning Website

Comments

@ssandino
Copy link
Member

ssandino commented Aug 2, 2024

Is there an existing request for this feature?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

If one subscribes for the newsletter on the page, the UX could slightly be optimized:

after1

Describe the solution/feature

  • After pressing the "subscribe/anmelden" button, the button should show a spinner while sending the data. We already use a spinner in the reset password form (search for showLoadingSpinner)
  • When data is successfully sent and toast appears the data in the form should be deleted (otherwise one is not that sure if it really sent, specially if one oversees the toast)
  • Add French as a language option for newsletter subscribers. The welcome series is ready and set up in the SendGrid platform. If someone subscribes on the French site, their language preference should be set to fr.

Describe alternatives you've considered

No response

Criteria for Completion

No response

Anything else?

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Social Income community
@ssandino ssandino added feature New feature or request website Issues concerning Website labels Aug 2, 2024
@ssandino
Copy link
Member Author

Even after the confirmation message (toast) Safari is warning to close the window or navigate to the home page, because the form fields are still filled in:

Screenshot 2024-08-10 at 16 29 20

@ssandino
Copy link
Member Author

@brennerthomas: Added a third sub-issue above: The website is now in French, so anyone signing up for the newsletter from the French site should have fr set as their language (like it does for de, and en stays the fallback for everyone)

@ssandino
Copy link
Member Author

ssandino commented Sep 8, 2024

@brennerthomas now we also have it as option for all the transactional emails, so if you could add this too! thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request website Issues concerning Website
Projects
None yet
Development

No branches or pull requests

2 participants