Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adobe RGB #17

Open
bjorn3 opened this issue Feb 21, 2017 · 17 comments
Open

Adobe RGB #17

bjorn3 opened this issue Feb 21, 2017 · 17 comments

Comments

@bjorn3
Copy link

bjorn3 commented Feb 21, 2017

Please support conversion to Adobe RGB.

@sobotka
Copy link
Owner

sobotka commented Feb 21, 2017

It is on the TODO. Sadly they are display referred, but I will support the transform.

@Eneen
Copy link

Eneen commented Jul 13, 2018

Any news on this?

@sobotka
Copy link
Owner

sobotka commented Jul 13, 2018

It will likely be added in the next wider gamut iteration, but not into this repository. The stanzas shouldn't be too difficult to design for those keen.

@Eneen
Copy link

Eneen commented Nov 1, 2020

Just a reminder, when to expect this?

@sobotka
Copy link
Owner

sobotka commented Nov 15, 2020

For input or display?

@Eneen
Copy link

Eneen commented Nov 15, 2020

I think both.

@sobotka
Copy link
Owner

sobotka commented Nov 15, 2020

You “think”? What is your context? Are you loading AdobeRGB imagery or do you have an AdobeRGB display?

@Eneen
Copy link

Eneen commented Nov 15, 2020

I'm using adobergb display (dell u2713h) and have some textures in adobergb, own made backplates mainly. They are currently converted into srgb ofc.

@sobotka
Copy link
Owner

sobotka commented Nov 15, 2020

OCIO v1 doesn’t provide a clean mechanism to clip out of gamut values, so you’ll need to take that into account in your own pipeline. Give me a few...

@Eneen
Copy link

Eneen commented Nov 15, 2020

Do you also plan to add Rec.2020 and DCI-P3? I don't use them but looks like they will be needed at some point.

sobotka added a commit that referenced this issue Nov 15, 2020
Both AdobeRGB displays and the generic display referred
encoding are supported with this commit.

Fixes #17.
@sobotka
Copy link
Owner

sobotka commented Nov 15, 2020

I'm not too concerned with things that people don't have or aren't using exclusively yet. It requires actual people with actual needs and hardware to test.

Please test https://github.com/sobotka/filmic-blender/tree/with-AdobeRGB

@Eneen
Copy link

Eneen commented Nov 16, 2020

Pure AdobeRGB works, but Filmic Log View Transform doesn't, on both sRGB and Adobe. I've checked master branch and it works ok there, for sRGB ofc.
On a daily basis I use config distributed with blender and I see that input color space naming has changed:

  • Non-Color is now Non-Color Data
  • sRGB is now sRGB OETF
    This way all maps are now switched into sRGB OETF. This is quite a problem with non-color maps like normals and roughness as it requires manual adjustment of all non-color maps in all current projects. Is it possible to keep previous names, just "sRGB" and "Non-Color"?

@sobotka
Copy link
Owner

sobotka commented Nov 16, 2020

Aliases are a part of OCIO v2. I’m not mangling up this config to appease Blender poor design choices. Other folks using other software use it too.

There are specific roles that are set and Blender should honour, but that’s on Blender.

https://github.com/sobotka/filmic-blender/blob/master/config.ocio#L22

What is wrong with the AdobeRGB Filmic Log specifically?

@Eneen
Copy link

Eneen commented Nov 16, 2020

For both sRGB and AdobeRGB Filmic log doesn't work, nothing happens when I switch into. Even greyscale doesn't work.

@sobotka
Copy link
Owner

sobotka commented Nov 16, 2020

Odd. It worked when I tested it. Will check when I have a moment later.

@Eneen
Copy link

Eneen commented Dec 4, 2020

Ah, my bad, looks like it works fine.
Take a look @ line 52, shouldn't be AdobeRGB there?
And line 199 in description, same thing.

@sobotka
Copy link
Owner

sobotka commented Dec 4, 2020

Good spot. The AdobeRGB wasn’t working obviously, due to being Apple’s Display P3. Give it a test. This is untested as I committed the fixes via the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants