-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hex colors #446
Comments
Did some work on this to avoid working on other things. 😉 @scottchiefbaker Does this look like a good direction for this? May need some more error checks but it appears to handle issue #438. Not really sure what
Edits updated code. |
@webstech this looks like a sensible start yes. I like your code style it's easy to read and understand. I'd need a little help (more comments) on exactly what the variables in Do you have it on a branch other people can play with? |
Hopefully tomorrow. Adding some tests for git-config. The changes will be at this branch. It has the first change in the series and is based on
Yes it does. I use Windows, so installing the sub-modules was best done under wsl but of course I did know that until after having installed them. The bats |
PR #453 has been opened as a first step in this change series. Follow-up patches will implement the hex colors support. |
Follow-up for #423.
Please support hex color codes like git does in diff-so-fancy, so that we can have smoothly integrated, unobtrusive background colors like this:
The text was updated successfully, but these errors were encountered: