From b3971885c89e5e88111e53361339802a25eafecf Mon Sep 17 00:00:00 2001 From: Abdelrahman Shawki Hassan Date: Wed, 23 Oct 2024 11:44:08 +0200 Subject: [PATCH] fix: use code security panel for quality --- src/snyk/snykCode/constants/analysis.ts | 1 - .../views/suggestion/codeSuggestionWebviewProvider.ts | 11 +++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/src/snyk/snykCode/constants/analysis.ts b/src/snyk/snykCode/constants/analysis.ts index bddf12454..34c606b2d 100644 --- a/src/snyk/snykCode/constants/analysis.ts +++ b/src/snyk/snykCode/constants/analysis.ts @@ -11,4 +11,3 @@ export const DIAGNOSTICS_OSS_COLLECTION_NAME = 'Snyk Open Source Security'; export const DIAGNOSTICS_OSS_COLLECTION_NAME_LS = 'Snyk Open Source'; export const WEBVIEW_PANEL_SECURITY_TITLE = 'Snyk Code Issue'; -export const WEBVIEW_PANEL_QUALITY_TITLE = 'Snyk Code Issue'; diff --git a/src/snyk/snykCode/views/suggestion/codeSuggestionWebviewProvider.ts b/src/snyk/snykCode/views/suggestion/codeSuggestionWebviewProvider.ts index 8bae2ade7..1d4bb55e2 100644 --- a/src/snyk/snykCode/views/suggestion/codeSuggestionWebviewProvider.ts +++ b/src/snyk/snykCode/views/suggestion/codeSuggestionWebviewProvider.ts @@ -23,10 +23,9 @@ import { ExtensionContext } from '../../../common/vscode/extensionContext'; import { IVSCodeLanguages } from '../../../common/vscode/languages'; import { IVSCodeWindow } from '../../../common/vscode/window'; import { IVSCodeWorkspace } from '../../../common/vscode/workspace'; -import { WEBVIEW_PANEL_QUALITY_TITLE, WEBVIEW_PANEL_SECURITY_TITLE } from '../../constants/analysis'; +import { WEBVIEW_PANEL_SECURITY_TITLE } from '../../constants/analysis'; import { messages as errorMessages } from '../../messages/error'; import { getAbsoluteMarkerFilePath } from '../../utils/analysisUtils'; -import { encodeExampleCommitFixes } from '../../utils/htmlEncoder'; import { generateDecorationOptions } from '../../utils/patchUtils'; import { IssueUtils } from '../../utils/issueUtils'; import { ICodeSuggestionWebviewProvider } from '../interfaces'; @@ -99,12 +98,12 @@ export class CodeSuggestionWebviewProvider try { await this.focusSecondEditorGroup(); if (this.panel) { - this.panel.title = this.getTitle(issue); + this.panel.title = this.getTitle(); this.panel.reveal(vscode.ViewColumn.Two, true); } else { this.panel = vscode.window.createWebviewPanel( SNYK_VIEW_SUGGESTION_CODE, - this.getTitle(issue), + this.getTitle(), { viewColumn: vscode.ViewColumn.Two, preserveFocus: true, @@ -376,7 +375,7 @@ export class CodeSuggestionWebviewProvider ]; } - private getTitle(issue: Issue): string { - return issue.additionalData.isSecurityType ? WEBVIEW_PANEL_SECURITY_TITLE : WEBVIEW_PANEL_QUALITY_TITLE; + private getTitle(): string { + return WEBVIEW_PANEL_SECURITY_TITLE; } }