GitHub module ignores contributors with private email

[jkbszpg]

When contributing code using the web interface GitHub can hide their real email and instead [email protected] is used

[email protected] is also supported by GitHub - https://github.blog/2017-04-11-private-emails-now-more-private/

Both email forms can be used from any git tool as well.

In current version these contributions are not counted

snyk-scm-contributors-count/src/lib/github/github-contributors.ts

Line 140 in d4e67c5

!commit.commit.author.email.endsWith('@users.noreply.github.com') &&

[IlanTSnyk]

Hi @jkbszpg ,
We do not count any commits from emails that end with 'noreply.gthub.com' to keep in line with Snyk's policy to not count those (these email postfixes originate from UI commits from non company related users).
However, when the same user name is found twice with different emails (like [email protected] and [email protected]) we will indicate that the user is duplicate in the tool's output.

Hope that makes sense.
Thank you.

[jkbszpg]

(these email postfixes originate from UI commits from non company related users).

not quite...

users can set their git desktop email to @users.noreply.github.com,
or interact with repository only via github web UI and never even have a git client installed.

In these cases, there will be no commits without @users.noreply.github.com for them anywhere in the system