From be429fedb6e86d9a25f798cecc73891c17b8668d Mon Sep 17 00:00:00 2001 From: Joshua Fuller Date: Sat, 26 Aug 2023 10:52:49 -0500 Subject: [PATCH] Title: Fix gpspipe argument incompatibility in constants.py for Rocky Linux 8 Body: On Rocky Linux 8 with gpspipe version 3.19, the `--json` argument is unsupported, causing Lincot to fail during execution. The issue was reported in GitHub issue #[Issue_Number]. The constants.py file contained a string `DEFAULT_GPS_INFO_CMD` which was using this incompatible `--json` argument. This commit replaces the `--json` argument with `-w` in the `DEFAULT_GPS_INFO_CMD` string, making the gpspipe command compatible across different versions. File Changed: - Modified DEFAULT_GPS_INFO_CMD in constants.py from `gpspipe --json -n 5` to `gpspipe -w -n 5`. Tested: - Manually tested on Rocky Linux 8 with gpspipe version 3.19 and confirmed that Lincot now runs without errors. This change should make Lincot more robust and compatible across different Linux distributions and gpspipe versions. --- lincot/constants.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lincot/constants.py b/lincot/constants.py index e0486e6..338bc40 100644 --- a/lincot/constants.py +++ b/lincot/constants.py @@ -25,4 +25,4 @@ DEFAULT_COT_TYPE: str = "a-f-G-E-S" DEFAULT_POLL_INTERVAL: int = 61 -DEFAULT_GPS_INFO_CMD: str = "gpspipe --json -n 5" +DEFAULT_GPS_INFO_CMD: str = "gpspipe -w -n 5"