-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changed file information to snow log #144
Comments
I'd like to take this issue (if it's still open) |
@belkarx Awesome, let us know if you have any questions. It's pretty simple, you pass two commits, and can query the results const diff = new Diff(commit0, commit1, { includeDirs: true });
...
const addedItems = Array.from(diff.added());
const modifiedItems = Array.from(diff.modified());
... Also check out 7.repo.diff.ts for more examples |
Hey, sorry for not getting on this earlier but I ran into some issues getting snow to work on my platform (Arch Linux). I submitted a bug report (#247) and in the meantime, I have a question: should I write a test for the |
Feel free to join us on Discord: https://discord.gg/cbrTXuYKR7 We are happy to help to get started @daniellanner: Do you remember if |
Hi @belkarx, No worries. EDIT: Regarding open source contributions, you are already doing the right thing by just asking questions 👍 Usually, you find detailed instructions on how to contribute in a repositories CONTRBUTING.md. In our case we follow the "fork-and-pull" Git workflow.
You can also see the first timer's guide on the auth0 blog for resources and tips on how to get started. For tests, feel free to get inspired by already existing unit tests in the project. Generally try and stick to unit test best practices with set-up and tear-down. If you have any further questions feel free to ask them here or our Discord. And once again a big thank you for contributing ❤️ @seb-mtl |
Hey @daniellanner @sebastianrath is any work still pending on this issue . I would like to take it from here |
Limitation
Currently
snow log --output=json
returns the full snapshot of each commit. A typical view for plugins working with SnowFS will be to show the files modified for each commit. This means every plugin will reimplement a log-diff-view feature.Proposed Solution
We can add this functionality natively and add an option to
snow log
to print all files per commit or only changed files, e.g.The text was updated successfully, but these errors were encountered: