Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify unit tests #190

Open
colmsnowplow opened this issue Aug 8, 2022 · 1 comment
Open

Simplify unit tests #190

colmsnowplow opened this issue Aug 8, 2022 · 1 comment

Comments

@colmsnowplow
Copy link
Collaborator

colmsnowplow commented Aug 8, 2022

In v1, we added a lot of unit test coverage, which is great. In some areas, however, they're overcomplicated. The transform/engine tests, and the trasformconfig validation tests, for example.

The latter of these has a tendency to panic because it relies on retrieving indexes from slices, when some changes mean they don't exist.

@TiganeteaRobert
Copy link
Contributor

I agree that the tests are overcomplicated, I feel that besides simplifying the tests we should also better document them and refactor them so they are more readable. Going over the JS/Lua tests for example with no prior interaction with the custom transformations was a tad overwhelming so I would love to make them friendlier.

This was referenced Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants