Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback request #1

Open
beautah opened this issue Jul 15, 2022 · 2 comments
Open

Feedback request #1

beautah opened this issue Jul 15, 2022 · 2 comments

Comments

@beautah
Copy link
Contributor

beautah commented Jul 15, 2022

@jomey @micahjohnson150 @micah-prime

take a look a the notebook in this repo, its got a quick overview. Please share with whomever and funnel feedback here, modify the json into a structure you might prefer, comment on further args that could be used, etc.

I'd welcome any feedback whatsoever,

Thanks

@micah-prime
Copy link

@beautah thanks for asking for our input on this! Sorry for the delay.

This looks great. Everything that we use is in those responses and I like having the units accessible in the data response.

In the getData endpoint, returning a dictionary of element code to the underlying data instead of a list of dictionaries with the element code as an entry in the dictionaries might make things mildly quicker for my use case, but the gain is trivial so I could go either way.

Any thoughts for what the station search endpoint would look like?

@beautah
Copy link
Contributor Author

beautah commented Jul 28, 2022

I mocked to endpoint returns here:
Here for data
getData
And here for station meta data
getMeta

You can examine the proposed args here (under the dev namespace), for each method, I'd imagine you could guess what the search args would be for the endpoint return I mocked up, but if not I could provide you with the url that would result in those json objects. feel free to ask more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants