Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extendio and lorax #216

Open
1 of 3 tasks
plastikfan opened this issue Aug 30, 2024 · 2 comments
Open
1 of 3 tasks

remove extendio and lorax #216

plastikfan opened this issue Aug 30, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file refactor Refactor code

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Aug 30, 2024

replace with li18ngo, traverse and pants.

@plastikfan plastikfan added refactor Refactor code dependencies Pull requests that update a dependency file labels Aug 30, 2024
@plastikfan plastikfan self-assigned this Aug 30, 2024
@plastikfan
Copy link
Contributor Author

There is a strange error occuring when we try to build:

# github.com/snivilised/pixa/src/app/cfg.test
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).cleanGlobPathWindows: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.NewPathIterator[go.shape.*uint8]: relocation target path/filepath.volumeNameLen not defined
# github.com/snivilised/pixa/src/app/proxy/user
src/app/proxy/user/ui-textual.go:66:44: slog.Logger.Error arg "err" should be a string or a slog.Attr (possible missing key or value)
FAIL	github.com/snivilised/pixa/src/app/cfg [build failed]
# github.com/snivilised/pixa/src/app/command.test
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).SplitAbs: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).cleanGlobPathWindows: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.NewPathIterator[go.shape.*uint8]: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[*github.com/avfs/avfs/vfs/memfs.MemFS]).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs/vfs/memfs.(*MemFS).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
FAIL	github.com/snivilised/pixa/src/app/command [build failed]
?   	github.com/snivilised/pixa/src/app/main	[no test files]
?   	github.com/snivilised/pixa/src/app/plog	[no test files]
# github.com/snivilised/pixa/src/app/proxy.test
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).SplitAbs: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[go.shape.*uint8]).cleanGlobPathWindows: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.NewPathIterator[go.shape.*uint8]: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs.(*Utils[*github.com/avfs/avfs/vfs/memfs.MemFS]).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
github.com/avfs/avfs/vfs/memfs.(*MemFS).VolumeNameLen: relocation target path/filepath.volumeNameLen not defined
FAIL	github.com/snivilised/pixa/src/app/proxy [build failed]
?   	github.com/snivilised/pixa/src/app/proxy/common	[no test files]
?   	github.com/snivilised/pixa/src/app/proxy/ipc	[no test files]
?   	github.com/snivilised/pixa/src/app/proxy/orc	[no test files]
FAIL	github.com/snivilised/pixa/src/app/proxy/user [build failed]
?   	github.com/snivilised/pixa/src/internal/matchers	[no test files]
?   	github.com/snivilised/pixa/src/internal/helpers	[no test files]
?   	github.com/snivilised/pixa/test/helpers	[no test files]
ok  	github.com/snivilised/pixa/src/app/proxy/filing	2.710s
ok  	github.com/snivilised/pixa/src/locale	5.211s

This is caused by avfs required by extendio, so we neer to remove extendio completely in a single swoop, to avoid indirectly depending on avfs. This means dealing with i18n, storage worker pool all at the same time, rather than doing peacemeal, dealing with a single issue at a time.

This could be painful ...

plastikfan added a commit that referenced this issue Oct 9, 2024
ref(locale): rename i18n to locale (#216)

ref(locale): use go-i18n.Message directly instead of extendio (#216)
@plastikfan
Copy link
Contributor Author

plastikfan commented Oct 26, 2024

This issue is given me good reasons to think we might have to give up on pixa and start again with a fresh repo. The extendio based navigator is far too deeply installed into the code base that it would be easier to just start from scratch, copying over the functionality on an incremental basis.

And it would be best to really make sure that this project is genuinely de-coupled from magick, but still be able to support it. On a mac there is another command line util for image processing and that is sips.

Also, I'm not really sure I like the entry point model, jars a bit, think up another, might need to research other cli applications on github to get some inspiration; the key thing is to have a clear separation between the cobra cli plumbing and the core application, that the entry point model was trying to acheive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor Refactor code
Projects
None yet
Development

No branches or pull requests

1 participant