Public Rooms cannot be found on Snikket servers when the searching user has an account on a different server

[p42ity]

If a user has an account on example.ORG and searches for public rooms on a different Snikket server (e.g. example.COM), this user cannot find any public rooms (even if there are public rooms). People on example.com can find public rooms on example.com.

@Zash has identified that this behavior changed because of: #199

Might be related to: https://issues.prosody.im/1866

Is this a wanted behaviour or is this a bug?

[mwild1]

It was something I was moving towards, though the change was unintentional for this release.

As mentioned in the past, Snikket instances/apps are not really designed for hosting public channels (which need moderation tooling, etc.), and we have also had cases of people unintentionally creating public channels, with the assumption that they are private.

This new behaviour is a safer default, though I was still internally debating what kind of overrides we would have for it, if any. This partially applies to Prosody, too, though of course behaviour will ultimately be fully configurable there.