Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace handling #6

Open
singpolyma opened this issue Aug 29, 2023 · 0 comments
Open

Namespace handling #6

singpolyma opened this issue Aug 29, 2023 · 0 comments

Comments

@singpolyma
Copy link
Collaborator

We may not want to use our own Stanza/XML element implementation at all (since I expect it to be more performant to pass through to the underlying one) but assuming we do we'll need to be careful about it.

For example https://github.com/snikket-im/snikket-sdk/blob/main/xmpp/Stanza.hx#L126 is already buggy WRT namespace handling, assuming that if a namespace is specified it must be present as an xmlns attribute on the child (and not inherited from parent, grandparent, set by way of namespace prefix, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant