Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies #544

Open
mktcode opened this issue Apr 5, 2022 · 2 comments
Open

Circular dependencies #544

mktcode opened this issue Apr 5, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mktcode
Copy link
Contributor

mktcode commented Apr 5, 2022

I want to use my local copy of snapshot.js when working on the hub and/or UI. I use yarn link for that but I get this error:

image

Re-building it or running dev mode doesn't work. But what I noticed is this:

image

Circular dependencies... Well, that doesn't sound good. Some more searching later:

image

I checked out some older commits and it is like that for more than a year... at least. Imho already far too long and we just build up more and more technical debt. This should be fixed asap.

@mktcode mktcode added the bug Something isn't working label Apr 5, 2022
@mktcode mktcode self-assigned this Apr 5, 2022
@samuveth
Copy link
Contributor

samuveth commented Apr 5, 2022

Interesting. Not sure if this helps as a quick fix in your case but for the Ui I use yalc to add my local version of snapshot.js

@mktcode
Copy link
Contributor Author

mktcode commented Apr 5, 2022

Not such a big fan of yalc (after a quick read) since it creates/touches files (yalc.lock/package.json). I prefer the yarn/npm native solution. The problem here needs to be fixed anyway. It's enough for now to just fix the one circular dependency regarding voting. Will submit a PR in a bit. Technically this would introduce a breaking change -> major version update. Score repo would need this update then:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants