Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: We shouldn't show error message in the end of a proposal #4485

Closed
bonustrack opened this issue Jan 8, 2024 · 4 comments · Fixed by #4490 or snapshot-labs/snapshot-sequencer#273
Assignees
Labels
enhancement New feature or request

Comments

@bonustrack
Copy link
Member

bonustrack commented Jan 8, 2024

We should trigger the request in background without showing the error message, we can show the result directly. We should also have a way to not trigger calculate multiple time if few people request it in same time.

@samuveth
Copy link
Contributor

samuveth commented Jan 8, 2024

You mean the "results are calculating" message?

@samuveth samuveth changed the title Snapshot: we shouldn't show error message in the end of a proposal fix: We shouldn't show error message in the end of a proposal Jan 8, 2024
@wa0x6e wa0x6e self-assigned this Jan 8, 2024
@ChaituVR
Copy link
Member

Actually, with snapshot-labs/snapshot-sequencer#273 we still show an error message at the end of proposal, we need a background task, either on sequencer of webhook to trigger score calculation on proposal end

@wa0x6e
Copy link
Collaborator

wa0x6e commented Jan 11, 2024

Should already be a webhook task to trigger the computation on proposal end, to sequencer.

This pr is in case the first computation fail

@wa0x6e wa0x6e reopened this Jan 11, 2024
@ChaituVR
Copy link
Member

Should already be a webhook task to trigger the computation on proposal end, to sequencer.

This pr is in case the first computation fail

Correct 😮 i completely forgot about the get webhook we had

@wa0x6e wa0x6e added the enhancement New feature or request label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants