Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean ingestor code #308

Open
bonustrack opened this issue Mar 7, 2024 · 2 comments
Open

chore: clean ingestor code #308

bonustrack opened this issue Mar 7, 2024 · 2 comments
Assignees

Comments

@bonustrack
Copy link
Member

Currently in the ingestor code there is a lot of manipulations for example here where we build another object just to be in a format that works with the ingestor function:
https://github.com/snapshot-labs/snapshot-sequencer/blob/master/src/ingestor.ts#L111-L123
There is no typing too, we should try to clean this part.

@Sekhmet Sekhmet self-assigned this Mar 7, 2024
@Sekhmet
Copy link
Member

Sekhmet commented Mar 9, 2024

To get more context, do we here want to still keep ingestor functionality (input A goes in, we transform it to new format, new format is used in actions) or the goal here is to get rid of transformations and use raw input in actions itself?

@bonustrack
Copy link
Member Author

The goal is to get rid of transformation, format is already enforced by the EIP 712 type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants