fix: use --password-store=basic when launching Signal
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See snapcrafters#300 An upstream Chrome issue blocks the correct inovation of libsecret from within snap/flatpak environments, which means that Signal loses access to the encryption key used to encrypt the local database, and needs to be re-linked (losing all message history) every time it's launched.
jnsgruk
changed the title
--password-store=basic when launching Signal
|
Edit: disproved my own theory! Updated the PR description with more info. |
jnsgruk
force-pushed
the
basic-password-store
branch
from
63ceb90
to
d42fdb6
Compare
kenvandine
approved these changes
Oct 1, 2024
I don't think so -- for users that already use the keyring, things will carry on as normal. |
jnsgruk
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
jnsgruk
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
jnsgruk
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
jnsgruk
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
jnsgruk
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
merlijn-sebrechts
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
merlijn-sebrechts
temporarily deployed
to
Candidate Branch
GitHub Actions
Inactive
|
Can anyone say in which version the fix should have manifested? Or is this still pending? Also, would I see an effect on Windows with that fix (I don't mean the wrapper, which obviously won't ... I mean adding the argument)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300 🥳
Start Signal with
--password-store=basicand prevent it from trying to usegnome-libsecret, which as far as I can tell is broken in the Chrome implementation, inherited by Electron, and thus meaning that Signal keeps losing access to the encryption key for its database!This solution is less secure, but without it, Signal literally doesn't work on some platforms. The introduction of the
safeStorageAPI in Signal is relatively recent, and fraught with issues on multiple platforms:It appears to be broken in the Snap, Flatpak, official Deb and even on Windows - though this doesn't seem to be acknowledged by Signal.
My proposition is we merge this fix, and keep and eye on changes upstream, potentially removing this workaround once we have confidence it'll work!
Further info: