Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable the build:dns-fallback step from npm run generate #303

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Aug 1, 2024

This PR is broken into a few commits:

  1. Ignore the paths of the new snapcraft remote-build logs
  2. Enable a build step we were previously skipping due to proxy issues; this required an actual patch to the source, which I will propose upstream
  3. Remove some older build patterns/cleanup stuff
  4. Add the x11/wayland plugs - not sure why these weren't already in!

snap/snapcraft.yaml Outdated Show resolved Hide resolved
lengau
lengau previously approved these changes Aug 1, 2024
snap/snapcraft.yaml Outdated Show resolved Hide resolved
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you're removing the cleanup part. Is there no size difference anymore?

Secondly, I think the app has too many plugs, not too little. The extension already adds a bunch of plugs. You can see the resulting yaml with snapcraft expand-extensions. Or am I missing something?

@jnsgruk
Copy link
Member Author

jnsgruk commented Aug 1, 2024

@merlijn-sebrechts indeed - I've removed the ones already bought in by the extension in a later commit. Should be good now.

There is no size difference, I believe a lot more of this is taken care of automatically by the extension now.

@jnsgruk jnsgruk merged commit 801a5d9 into snapcrafters:candidate Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants