-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: enable the build:dns-fallback
step from npm run generate
#303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised you're removing the cleanup part. Is there no size difference anymore?
Secondly, I think the app has too many plugs, not too little. The extension already adds a bunch of plugs. You can see the resulting yaml with snapcraft expand-extensions
. Or am I missing something?
@merlijn-sebrechts indeed - I've removed the ones already bought in by the extension in a later commit. Should be good now. There is no size difference, I believe a lot more of this is taken care of automatically by the extension now. |
This PR is broken into a few commits:
snapcraft remote-build
logs