ci: install signal in desktop vm and take screenshots #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merlijn-sebrechts it worked!
|
|
@merlijn-sebrechts this is ready for review, I've tested the build all works and that the screenshots get uploaded, but obviously can't really test the code that happens after merge just yet! I've given it a couple of reads, and I think the variables etc. are all wired up correctly, but we'll see when it merges! |
merlijn-sebrechts
requested changes
Nov 25, 2023
merlijn-sebrechts
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test that adds the ability to launch a KVM accelerated desktop VM inside the Github Actions runner.
Once running, we push the built snap into the VM and run signal-desktop. From there, we can use
gnome-screenshotto get a screenshot of both the whole screen and the specific window we just launched.Then finish by pulling the screenshot files out of the VM and adding them in a comment on the call for testing post.