Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GH Action erroneously suggests promoting incorrect releases #204

Closed
popey opened this issue Nov 23, 2023 · 3 comments
Closed

[Bug]: GH Action erroneously suggests promoting incorrect releases #204

popey opened this issue Nov 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@popey
Copy link
Contributor

popey commented Nov 23, 2023

What happened?

In issue #201 - generated by a GH action (I believe) - the maintainers were told to promote revisions 34 and 35. These are not correct revisions. It should have suggested to promote 556 and 557.
As a result, if done without double-checking, the maintainers could (and did) easily promote an old, broken, insecure release. This shouldn't be allowed happen.

What should have happened?

The action should have informed the maintainer to promote the correct revisions.

Output of snap info $snap_name

Not relevant

Output of snap connections $snap_name

Not relevant

Output of snap version

Not relevant

Relevant log output

No response

Teminal output of app

No response

@popey popey added the bug Something isn't working label Nov 23, 2023
@popey
Copy link
Contributor Author

popey commented Nov 23, 2023

image

image

@merlijn-sebrechts
Copy link
Member

I see two issues

  1. The examples part of the bot text shouldn't contain numbers
  2. The bot should have some for of safeguard not to promote ancient versions

@merlijn-sebrechts
Copy link
Member

This is fixed now, thanks to @jnsgruk's incredible efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants