Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fprettify - did it break other functionality? #23

Open
smwesten-usgs opened this issue May 25, 2022 · 0 comments
Open

fprettify - did it break other functionality? #23

smwesten-usgs opened this issue May 25, 2022 · 0 comments

Comments

@smwesten-usgs
Copy link
Owner

In commit 15be47a, fprettify was applied to the codebase. It appears that this subtly modified the behavior of blocks of code, in particular 'series_sub' in tsp_equation_parser.F90. Since much of the original code used similar design patterns (do loop with several 'goto' statements as exit points), it may be that there are other subroutines that are similarly broken.

Not sure what the solution is here. Perhaps revert to the pre-fprettify version, then overlay other changes on top, then apply fprettify in a more measured manner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant