From 61982b89fdc10d54c778f872f5c2e155e40e65a3 Mon Sep 17 00:00:00 2001 From: Pedro Ramos Date: Wed, 31 Jan 2024 11:01:24 +0100 Subject: [PATCH] Rename one of the metrics --- src/recorder.ts | 4 ++-- test/recorder.spec.ts | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/recorder.ts b/src/recorder.ts index 0802500..0954bc6 100644 --- a/src/recorder.ts +++ b/src/recorder.ts @@ -16,9 +16,9 @@ export class Recorder { this.record(new Metric(name, MetricType.Gauge, value, metadata)); } - async recordActionExecuted(actionName: string, metadata: MetricMetadata = {}) { + async recordActionFinished(actionName: string, metadata: MetricMetadata = {}) { metadata['action'] = actionName; - this.record(new Metric('action.executed', MetricType.Counter, 1, metadata)); + this.record(new Metric('action.finished', MetricType.Counter, 1, metadata)); } async recordActionInvoked(actionName: string, metadata: MetricMetadata = {}) { metadata['action'] = actionName; diff --git a/test/recorder.spec.ts b/test/recorder.spec.ts index 8720900..49ac4cd 100644 --- a/test/recorder.spec.ts +++ b/test/recorder.spec.ts @@ -51,12 +51,12 @@ describe('Recorder', function() { expect(recorderMetricsSpy[0]).toEqual(expectedMetric); }); - it('recordActionExecuted()', async function() { + it('recordActionFinished()', async function() { const recorderMetricsSpy = []; const recorder = new Recorder('test', new testSink(), recorderMetricsSpy); - const expectedMetric = new Metric('test.action.executed', MetricType.Counter, 1, { action: 'validate', success: true }); + const expectedMetric = new Metric('test.action.finished', MetricType.Counter, 1, { action: 'validate', success: true }); - await recorder.recordActionExecuted('validate', { success: true }); + await recorder.recordActionFinished('validate', { success: true }); expect(recorderMetricsSpy).toHaveLength(1); expect(recorderMetricsSpy[0]).toEqual(expectedMetric); }); @@ -76,9 +76,9 @@ describe('Recorder', function() { const sink = new testSink(); const recorderMetricsSpy = []; const {recorder, stop} = WithPeriodicFlushRecorder(new Recorder('test', sink, recorderMetricsSpy), 100); - const expectedMetric = new Metric('test.action.executed', MetricType.Counter, 1, { action: 'validate', success: true }); + const expectedMetric = new Metric('test.action.finished', MetricType.Counter, 1, { action: 'validate', success: true }); - await recorder.recordActionExecuted('validate', { success: true }); + await recorder.recordActionFinished('validate', { success: true }); expect(recorderMetricsSpy).toHaveLength(1); expect(recorderMetricsSpy[0]).toEqual(expectedMetric);