Skip to content

Commit 2f1d17c

Browse files
committed
Consolidate messages.
1 parent 2fd8c47 commit 2f1d17c

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

equality.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ func shouldEqual(actual, expected any) string {
3434
}
3535
renderedExpected, renderedActual := render.Render(expected), render.Render(actual)
3636
if renderedActual == renderedExpected {
37-
message := fmt.Sprintf(shouldHaveResembledButTypeDiff, renderedExpected, renderedActual)
37+
message := fmt.Sprintf(shouldHaveBeenEqualButTypeDiff, renderedExpected, renderedActual)
3838
return serializer.serializeDetailed(expected, actual, message)
3939
}
40-
message := fmt.Sprintf(shouldHaveResembled, renderedExpected, renderedActual) +
40+
message := fmt.Sprintf(shouldHaveBeenEqual, renderedExpected, renderedActual) +
4141
composePrettyDiff(renderedExpected, renderedActual)
4242
return serializer.serializeDetailed(expected, actual, message)
4343
}

messages.go

+3-8
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
11
package assertions
22

33
const (
4-
shouldHaveBeenEqual = "Expected: '%v'\nActual: '%v'\n(Should be equal)"
5-
shouldHaveBeenEqualNoResemblance = "Both the actual and expected values render equally ('%s') and their types are the same. Try using ShouldResemble instead."
6-
shouldNotHaveBeenEqual = "Expected '%v'\nto NOT equal '%v'\n(but it did)!"
7-
shouldHaveBeenEqualTypeMismatch = "Expected: '%v' (%T)\nActual: '%v' (%T)\n(Should be equal, type mismatch)"
8-
94
shouldHaveBeenAlmostEqual = "Expected '%v' to almost equal '%v' (but it didn't)!"
105
shouldHaveNotBeenAlmostEqual = "Expected '%v' to NOT almost equal '%v' (but it did)!"
116

12-
shouldHaveResembled = "Expected: %s\nActual: %s\n(Should equal)!"
13-
shouldHaveResembledButTypeDiff = "Expected: %s\nActual: %s\n(Should equal, but there is a type difference within the two)!"
14-
shouldNotHaveResembled = "Expected '%#v'\nto NOT resemble '%#v'\n(but it did)!"
7+
shouldHaveBeenEqual = "Expected: %s\nActual: %s\n(Should equal)!"
8+
shouldHaveBeenEqualButTypeDiff = "Expected: %s\nActual: %s\n(Should equal, but there is a type difference within the two)!"
9+
shouldNotHaveBeenEqual = "Expected '%v'\nto NOT equal '%v'\n(but it did)!"
1510

1611
shouldBePointers = "Both arguments should be pointers "
1712
shouldHaveBeenNonNilPointer = shouldBePointers + "(the %s was %s)!"

0 commit comments

Comments
 (0)