smartplugin: add pause_item (instead of suspend item) #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onkelandy
reviewed
Jul 1, 2024
|
On merging, also merge smarthomeNG/plugins#945 to mitigate breaking changes to plugins using the old suspend_item mechanics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This item more or less replaces the suspend_item, but it hard-stops and re-runs the plugin instead of trying to suspend it while being active.
Modified and adjusten SmartPlugin and MqttPlugin as well as both sample plugins and their plugin.yaml files.
Works with adjusted zigbee2mqtt Plugin; plugin wishing to implement this need to
Also cleaned up SmartPlugin, commented the reason for using class members and added some type hinting.
As far as I can see, the changes should be non-breaking.