Skip to content

Commit 9aa48d4

Browse files
authored
Merge pull request #362 from smartdevicelink/bugfix/issue-361-update-pr-template
Update PR template to align with iOS / Java Suite
2 parents dbb0ab9 + 5f0673b commit 9aa48d4

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,25 @@
1-
[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](./CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @crokita.
1+
[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_javascript_suite/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Please create the PR as a draft until it is ready for review. Once this PR is ready for review, please request one from @crokita and mark the PR as ready for review.
22

33
Delete the above section when you've read it.]
44

55
Fixes #[issue number]
66

7-
This PR is **[ready / not ready]** for review.
8-
97
### Risk
108
This PR makes **[no / minor / major]** API changes.
119

1210
### Testing Plan
13-
[Describe how you plan to unit test the changes in this PR]
11+
- [ ] I have verified that I have not introduced new warnings in this PR (or explain why below)
12+
- [ ] I have run the unit tests with this PR
13+
- [ ] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
14+
15+
#### Unit Tests
16+
[Describe the unit tests and behaviors added in this PR]
17+
18+
#### Core Tests
19+
[List of tests performed against Core and behaviors verified]
20+
21+
Core version / branch / commit hash / module tested against: [INSERT]
22+
HMI name / version / branch / commit hash / module tested against: [INSERT]
1423

1524
### Summary
1625
[Summary of PR changes]
@@ -30,4 +39,4 @@ This PR makes **[no / minor / major]** API changes.
3039
- [ ] [Task 2]
3140

3241
### CLA
33-
- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform) and this pull request adheres to the [Contributing Guide](./CONTRIBUTING.md).
42+
- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)

0 commit comments

Comments
 (0)