Merge pull request #530 from smartdevicelink/bugfix/invalid-voice-commands-no-warning

Add warnings for invalid voice command strings

Author: crokita

lib/js/src/manager/screen/_VoiceCommandManagerBase.js

@@ -179,13 +179,20 @@ class _VoiceCommandManagerBase extends _SubManagerBase {
         const validatedVoiceCommands = voiceCommands.map((voiceCommand) => {
             const voiceCommandStrings = voiceCommand.getVoiceCommands().filter((voiceCommandString) => {
                 // filter out any whitespace characters
-                return voiceCommandString !== null && voiceCommandString !== undefined && voiceCommandString.replace(/\s/g, '').length > 0;
+                const validString = voiceCommandString !== null && voiceCommandString !== undefined && voiceCommandString.replace(/\s/g, '').length > 0;
+                if (!validString) {
+                    console.warn('Empty or whitespace only voice command string: ', voiceCommandString, ', removed from voice command: ', voiceCommand);
+                }
+                return validString;
             });
             // Updates voice command strings array by only adding ones that are not empty(e.g. ', ' ', ...)
             if (voiceCommandStrings.length > 0) {
                 return voiceCommand.setVoiceCommands(voiceCommandStrings);
             }
         }).filter((voiceCommand) => {
+            if (voiceCommand === undefined) {
+                console.warn('A voice command with no valid strings was removed.');
+            }
             return voiceCommand !== undefined;
         });
         return validatedVoiceCommands;