Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "PRIVATE_KEY" variable to "WALLET_PRIVATE_KEY" #165

Open
jule64 opened this issue Mar 10, 2023 · 4 comments
Open

Rename "PRIVATE_KEY" variable to "WALLET_PRIVATE_KEY" #165

jule64 opened this issue Mar 10, 2023 · 4 comments

Comments

@jule64
Copy link

jule64 commented Mar 10, 2023

I've just spent 1 hour in a Chainlink workshop struggling to start up hardhat because I assumed this variable was for the infura/alchemy private key.. I kept getting these "private key too short" error messages and even the bootcamp people didn't realise what the issue was.
Using a more explicit name for this variable could resolve any confusion as I imagine others might have faced this too..

@naman1402
Copy link

Can I work on this issue ?

@andrejrakic
Copy link
Contributor

@NamanMohnani, of course, go for it! Thanks for raising this issue, @jule64

@naman1402
Copy link

@andrejrakic Apparently I can not make changes in the .env file, am I supposed to make changes in the .env.example file ?

@naman1402
Copy link

@andrejrakic I've submitted my PR kindly check on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants