Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token pool ownership transfer #16596

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ecPablo
Copy link
Contributor

@ecPablo ecPablo commented Feb 26, 2025

Update the ccip transfer ownership changeset to include 2 new configs. A slice for burn-mint token pools and a slice for lock-release token pools. The changeset will transfer the ownership of each of the provided token pools and include them in the accept ownership proposal

AI Summary

This pull request includes several changes to the deployment/ccip/changeset/solana module, focusing on improving ownership transfer functionality and adding support for new token pools. The most important changes include adding new functions for transferring ownership of burn-mint and lock-release token pools, updating test cases to reflect these changes, and modifying existing functions to accommodate additional parameters.

Ownership transfer improvements:

Test case updates:

Function modifications:

Codebase enhancements:

Dependency additions:

Copy link
Contributor

github-actions bot commented Feb 26, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , test-scripts , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. File is not properly formatted (goimports):[Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-02-26T20:59:27.6142997Z ##[error]deployment/ccip/changeset/solana/transfer_ccip_to_mcms_with_timelock_test.go:16:1: File is not properly formatted (goimports)
Golang Lint (deployment)	2025-02-26T20:59:27.6144092Z 	"github.com/gagliardetto/solana-go"
Golang Lint (deployment)	2025-02-26T20:59:27.6144490Z ^

Why: The error indicates that the file transfer_ccip_to_mcms_with_timelock_test.go is not formatted according to goimports standards. This typically means that the import statements or code structure do not adhere to the expected format.

Suggested fix: Run goimports on the file to automatically format it. This can be done by executing goimports -w deployment/ccip/changeset/solana/transfer_ccip_to_mcms_with_timelock_test.go in the terminal.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

yashnevatia
yashnevatia previously approved these changes Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants