Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/ccip/changeset: more parallel tests #16588

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Feb 26, 2025

ok  	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/solana	510.510s
ok  	github.com/smartcontractkit/chainlink/deployment/ccip/changeset/v1_6	293.344s

Copy link
Contributor

github-actions bot commented Feb 26, 2025

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , GolangCI Lint (.) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. (*testing.common).Logf does not support error-wrapping directive %w:[Golang Lint (deployment)]

Source of Error:
deployment/environment/memory/environment.go:204:3: printf: (*testing.common).Logf does not support error-wrapping directive %w (govet)
	t.Logf("failed to take %v ports: %w", n, err)
	^
**Why**: The `Logf` method from the `testing` package does not support the `%w` directive for error wrapping. This directive is used for wrapping errors in Go, but `Logf` expects standard formatting directives.

Suggested fix: Replace %w with %v or %s to format the error without wrapping.

2. (*testing.common).Logf call has arguments but no formatting directives:[Golang Lint (deployment)]

Source of Error:
deployment/environment/memory/environment.go:211:8: printf: (*testing.common).Logf call has arguments but no formatting directives (govet)
	t.Logf("DEBUG", "Test %q took ports %v", t.Name(), ports)
	 ^
**Why**: The `Logf` method is called with arguments but the first argument does not contain any formatting directives.

Suggested fix: Remove the extra argument "DEBUG" or include it in the format string.

3. (*testing.common).Logf call has arguments but no formatting directives:[Golang Lint (deployment)]

Source of Error:
deployment/environment/memory/environment.go:214:9: printf: (*testing.common).Logf call has arguments but no formatting directives (govet)
	t.Logf("DEBUG", "Test %q returned ports %v", t.Name(), ports)
		 ^
**Why**: Similar to the previous error, the `Logf` method is called with arguments but the first argument does not contain any formatting directives.

Suggested fix: Remove the extra argument "DEBUG" or include it in the format string.

4. freeport: cannot allocate port block:[Run tests]

Source of Error:
--- FAIL: TestDeployCapabilityRegistry (0.10s)
panic: freeport: cannot allocate port block [recovered]
	panic: freeport: cannot allocate port block
...
github.com/hashicorp/consul/sdk/freeport.alloc()
	/home/runner/go/pkg/mod/github.com/hashicorp/consul/[email protected]/freeport/freeport.go:274 +0xad
github.com/hashicorp/consul/sdk/freeport.initialize()
	/home/runner/go/pkg/mod/github.com/hashicorp/consul/[email protected]/freeport/freeport.go:124 +0x2d7
sync.(*Once).doSlow(0x7f2af0aecb08?, 0x7f2b3c78af30?)
	/opt/hostedtoolcache/go/1.24.0/x64/src/sync/once.go:78 +0xab
sync.(*Once).Do(...)
	/opt/hostedtoolcache/go/1.24.0/x64/src/sync/once.go:69
github.com/hashicorp/consul/sdk/freeport.Take(0x1)
	/home/runner/go/pkg/mod/github.com/hashicorp/consul/[email protected]/freeport/freeport.go:303 +0xe5
github.com/smartcontractkit/chainlink/deployment/environment/memory.WaitForPorts(0xc000583340, 0x1)
	/home/runner/work/chainlink/chainlink/deployment/environment/memory/environment.go:200 +0x5a
**Why**: The `freeport` library is unable to allocate a block of ports, possibly due to exhaustion of available ports or misconfiguration.

Suggested fix: Ensure that there are enough available ports for allocation. Check for any port leaks or increase the range of available ports.

5. Process completed with exit code 1:[Check Golangci-lint Matrix Results]

Source of Error:
Check Golangci-lint Matrix Results	2025-02-26T15:30:29.8333210Z ##[error]Process completed with exit code 1.
**Why**: The GolangCI Lint job failed due to the linting errors found in the code.

Suggested fix: Fix the identified linting issues in the codebase to ensure the GolangCI Lint job passes successfully.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@jmank88 jmank88 changed the title deployment/ccip/changeset/solana: more parallel tests deployment/ccip/changeset: more parallel tests Feb 26, 2025
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants