Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sub-second reports #16575

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Support sub-second reports #16575

wants to merge 1 commit into from

Conversation

samsondav
Copy link
Collaborator

@samsondav samsondav commented Feb 25, 2025

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Clean Go Tidy & Generate , Detect Changes , GolangCI Lint (.) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , SonarQube Scan , lint

1. Missing go.mod file for chainlink-data-streams dependency:go_core_race_tests

Source of Error:
go: github.com/smartcontractkit/chainlink-data-streams@v0.1.1-0.20250224190032-809e4b8cf29e (replaced by /Users/sam/code/smartcontractkit/chainlink-data-streams): reading /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: open /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: no such file or directory
**Why**: The Go module `chainlink-data-streams` is being replaced by a local path, but the `go.mod` file is missing in the specified directory.

Suggested fix: Ensure that the go.mod file exists in the /Users/sam/code/smartcontractkit/chainlink-data-streams directory or update the path to the correct location.

2. Missing go.mod file for chainlink-data-streams dependency:go_core_tests_integration

Source of Error:
go: github.com/smartcontractkit/chainlink-data-streams@v0.1.1-0.20250224190032-809e4b8cf29e (replaced by /Users/sam/code/smartcontractkit/chainlink-data-streams): reading /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: open /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: no such file or directory
**Why**: The Go module `chainlink-data-streams` is being replaced by a local path, but the `go.mod` file is missing in the specified directory.

Suggested fix: Ensure that the go.mod file exists in the /Users/sam/code/smartcontractkit/chainlink-data-streams directory or update the path to the correct location.

3. Undefined fields in report struct: test-scripts

Source of Error:
../services/llo/evm/report_codec_common.go:12:16: report.ValidAfterNanoseconds undefined (type "github.com/smartcontractkit/chainlink-data-streams/llo".Report has no field or method ValidAfterNanoseconds)
../services/llo/evm/report_codec_common.go:13:16: report.ObservationTimestampNanoseconds undefined (type "github.com/smartcontractkit/chainlink-data-streams/llo".Report has no field or method ObservationTimestampNanoseconds)
**Why**: The `Report` struct from the `chainlink-data-streams/llo` package does not contain the fields `ValidAfterNanoseconds` and `ObservationTimestampNanoseconds`.

Suggested fix: Verify the Report struct definition in the chainlink-data-streams/llo package and update the code to use the correct fields.

4. Missing go.mod file for chainlink-data-streams dependency:go_core_ccip_deployment_tests

Source of Error:
go: github.com/smartcontractkit/chainlink-data-streams@v0.1.1-0.20250224190032-809e4b8cf29e (replaced by /Users/sam/code/smartcontractkit/chainlink-data-streams): reading /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: open /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: no such file or directory
**Why**: The Go module `chainlink-data-streams` is being replaced by a local path, but the `go.mod` file is missing in the specified directory.

Suggested fix: Ensure that the go.mod file exists in the /Users/sam/code/smartcontractkit/chainlink-data-streams directory or update the path to the correct location.

5. Undefined fields and methods in TestApplication struct: GolangCI Lint (.)

Source of Error:
core/internal/cltest/cltest.go:266:38: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:269:34: app.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:288:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:290:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:292:27: app.GetKeyStore undefined (type *TestApplication has no field or method GetKeyStore) (typecheck)
core/internal/cltest/cltest.go:659:12: ta.GetDB undefined (type *TestApplication has no field or method GetDB) (typecheck)
core/internal/cltest/cltest.go:666:27: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:667:15: ta.KeyStore undefined (type *TestApplication has no field or method KeyStore) (typecheck)
core/internal/cltest/cltest.go:695:11: ta.BasicAdminUsersORM undefined (type *TestApplication has no field or method BasicAdminUsersORM) (typecheck)
core/internal/cltest/cltest.go:717:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
core/internal/cltest/cltest.go:736:38: ta.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
core/internal/cltest/cltest.go:1328:95: app.GetConfig undefined (type *TestApplication has no field or method GetConfig) (typecheck)
**Why**: The `TestApplication` struct is missing the fields or methods `KeyStore`, `GetKeyStore`, `GetDB`, `BasicAdminUsersORM`, and `GetConfig`.

Suggested fix: Verify the TestApplication struct definition and ensure it includes the required fields and methods.

6. Undefined fields and methods in various structs: GolangCI Lint (.)

Source of Error:
core/capabilities/integration_tests/framework/don.go:291:18: node.Stop undefined (type *capabilityNode has no field or method Stop) (typecheck)
core/capabilities/integration_tests/framework/don.go:368:15: node.AddJobV2 undefined (type *capabilityNode has no field or method AddJobV2) (typecheck)
core/cmd/admin_commands.go:147:12: p.Role undefined (type *AdminUsersPresenter has no field or method Role) (typecheck)
core/cmd/admin_commands.go:148:5: p.HasActiveApiToken undefined (type *AdminUsersPresenter has no field or method HasActiveApiToken) (typecheck)
core/cmd/admin_commands.go:149:5: p.CreatedAt undefined (type *AdminUsersPresenter has no field or method CreatedAt) (typecheck)
core/cmd/admin_commands.go:150:5: p.UpdatedAt undefined (type *AdminUsersPresenter has no field or method UpdatedAt) (typecheck)
core/cmd/admin_commands.go:219:29: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
core/cmd/admin_commands.go:220:75: user.Email undefined (type AdminUsersPresenter has no field or method Email) (typecheck)
core/cmd/aptos_keys_commands.go:30:5: p.PubKey undefined (type *AptosKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/blocks_commands.go:100:20: p.EVMChainID undefined (type *LCAPresenter has no field or method EVMChainID) (typecheck)
core/cmd/bridge_commands.go:50:37: p.Confirmations undefined (type *BridgePresenter has no field or method Confirmations) (typecheck)
core/cmd/bridge_commands.go:57:5: p.Name undefined (type *BridgePresenter has no field or method Name) (typecheck)
core/cmd/bridge_commands.go:58:5: p.URL undefined (type *BridgePresenter has no field or method URL) (typecheck)
core/cmd/bridge_commands.go:60:5: p.OutgoingToken undefined (type *BridgePresenter has no field or method OutgoingToken) (typecheck)
core/cmd/bridge_commands.go:73:6: p.Name undefined (type BridgePresenter has no field or method Name) (typecheck)
core/cmd/bridge_commands.go:74:6: p.URL undefined (type BridgePresenter has no field or method URL) (typecheck)
core/cmd/chains_commands.go:70:20: p.GetID undefined (type *ChainPresenter has no field or method GetID) (typecheck)
core/cmd/cosmos_keys_commands.go:30:5: p.PubKey undefined (type *CosmosKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/cosmos_transaction_commands.go:50:7: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
core/cmd/cosmos_transaction_commands.go:51:13: p.TxHash undefined (type *CosmosMsgPresenter has no field or method TxHash) (typecheck)
core/cmd/cosmos_transaction_commands.go:54:5: p.ChainID undefined (type *CosmosMsgPresenter has no field or method ChainID) (typecheck)
core/cmd/cosmos_transaction_commands.go:55:5: p.ContractID undefined (type *CosmosMsgPresenter has no field or method ContractID) (typecheck)
core/cmd/cosmos_transaction_commands.go:56:5: p.State undefined (type *CosmosMsgPresenter has no field or method State) (typecheck)
core/cmd/csa_keys_commands.go:85:5: p.PubKey undefined (type *CSAKeyPresenter has no field or method PubKey) (typecheck)
core/cmd/eth_keys_commands.go:128:7: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
core/cmd/eth_keys_commands.go:129:11: p.EthBalance undefined (type *EthKeyPresenter has no field or method EthBalance) (typecheck)
core/cmd/eth_keys_commands.go:132:7: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
core/cmd/eth_keys_commands.go:133:12: p.LinkBalance undefined (type *EthKeyPresenter has no field or method LinkBalance) (typecheck)
core/cmd/eth_keys_commands.go:136:7: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
core/cmd/eth_keys_commands.go:137:11: p.MaxGasPriceWei undefined (type *EthKeyPresenter has no field or method MaxGasPriceWei) (typecheck)
core/cmd/eth_keys_commands.go:140:5: p.Address undefined (type *EthKeyPresenter has no field or method Address) (typecheck)
core/cmd/eth_keys_commands.go:141:5: p.EVMChainID undefined (type *EthKeyPresenter has no field or method EVMChainID) (typecheck)
core/cmd/eth_keys_commands.go:144:23: p.Disabled undefined (type *EthKeyPresenter has no field or method Disabled) (typecheck)
core/cmd/eth_keys_commands.go:145:5: p.CreatedAt undefined (type *EthKeyPresenter has no field or method CreatedAt) (typecheck)
core/cmd/eth_keys_commands.go:146:5: p.UpdatedAt undefined (type *EthKeyPresenter has no field or method UpdatedAt) (typecheck)
core/cmd/evm_transaction_commands.go:78:5: p.From undefined (type *EthTxPresenter has no field or method From) (typecheck)
core/cmd/evm_transaction_commands.go:79:5: p.Nonce undefined (type *EthTxPresenter has no field or method Nonce) (typecheck)
core/cmd/evm_transaction_commands.go:80:5: p.To undefined (type *EthTxPresenter has no field or method To) (typecheck)
**Why**: Various structs are missing fields or methods that are being referenced in the code.

Suggested fix: Verify the definitions of the affected structs and ensure they include the required fields and methods.

7. Missing go.mod file for chainlink-data-streams dependency:go_core_fuzz

Source of Error:
go: github.com/smartcontractkit/chainlink-data-streams@v0.1.1-0.20250224190032-809e4b8cf29e (replaced by /Users/sam/code/smartcontractkit/chainlink-data-streams): reading /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: open /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: no such file or directory
**Why**: The Go module `chainlink-data-streams` is being replaced by a local path, but the `go.mod` file is missing in the specified directory.

Suggested fix: Ensure that the go.mod file exists in the /Users/sam/code/smartcontractkit/chainlink-data-streams directory or update the path to the correct location.

8. Missing go.mod file for chainlink-data-streams dependency:go_core_tests

Source of Error:
go: github.com/smartcontractkit/chainlink-data-streams@v0.1.1-0.20250224190032-809e4b8cf29e (replaced by /Users/sam/code/smartcontractkit/chainlink-data-streams): reading /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: open /Users/sam/code/smartcontractkit/chainlink-data-streams/go.mod: no such file or directory
**Why**: The Go module `chainlink-data-streams` is being replaced by a local path, but the `go.mod` file is missing in the specified directory.

Suggested fix: Ensure that the go.mod file exists in the /Users/sam/code/smartcontractkit/chainlink-data-streams directory or update the path to the correct location.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@samsondav samsondav force-pushed the MERC-6852 branch 4 times, most recently from 1af2f3d to ee551e7 Compare February 27, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant