Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bash wrappers and invoke solidity compilation directly. #16568

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Remove bash wrappers and invoke solidity compilation directly. #16568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598dd9b
Minor
pavel-raykov Feb 25, 2025
4b715ba
Minor
pavel-raykov Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-suits-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

#removed Remove bash wrappers and call solidity compilation directly.
32 changes: 0 additions & 32 deletions core/gethwrappers/generation/compile_contracts.sh
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions core/gethwrappers/generation/compile_event_mock_contract.sh
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions core/gethwrappers/go_generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
package gethwrappers

// Make sure solidity compiler artifacts are up-to-date. Only output stdout on failure.
//go:generate ./generation/compile_contracts.sh
//go:generate ../../contracts/scripts/native_solc_compile_all

//go:generate go run ./generation/generate/wrap.go ../../contracts/solc/v0.8.19/Operator/Operator.abi ../../contracts/solc/v0.8.19/Operator/Operator.bin Operator operator_wrapper
//go:generate go run ./generation/generate/wrap.go ../../contracts/solc/v0.8.19/OperatorFactory/OperatorFactory.abi ../../contracts/solc/v0.8.19/OperatorFactory/OperatorFactory.bin OperatorFactory operator_factory
Expand Down Expand Up @@ -161,6 +161,6 @@ package gethwrappers
// The flow is as follows:
// 1. Compile all non events mock contracts.
// 2. Generate events mock .sol files based on ABI of compiled contracts.
// 3. Compile events mock contracts. ./generation/compile_event_mock_contract.sh calls contracts/scripts/native_solc_compile_all_events_mock to compile events mock contracts.
// 3. Compile mocks by calling contracts/scripts/native_solc_compile_all_events_mock to compile events mock contracts.
// 4. Generate wrappers for events mock contracts.
//go:generate ./generation/compile_event_mock_contract.sh
//go:generate ../../contracts/scripts/native_solc_compile_all_events_mock
Loading