Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more realistic values for FeeQuoter configs #16558

Closed
wants to merge 1 commit into from

Conversation

asoliman92
Copy link
Contributor

Use more realistic values for FeeQuoter configs

@cl-sonarqube-production
Copy link

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. Error reading from connection:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.7682261Z logger.go:146: 2025-02-25T10:50:58.772Z	WARN	oracle_streams_0.SingletonPeerWrapper	ragep2p/ragep2p.go:1263	Error reading from connection	{"version": "unset@unset", "remotePeerID": "12D3KooWJMcGgCvPz2Vyo2u5MQmhRmAqqT4iqjU4RtpLtbzobWEd", "direction": "in", "remoteAddr": "127.0.0.1:42598", "id": "ragep2p", "peerID": "12D3KooWRcx3XVKoD9TNHopjESqfRV2HWadYehKEsRibXSwwTrRv", "error": "EOF"}
**Why**: This error indicates that the connection was unexpectedly closed by the remote peer, resulting in an EOF (End of File) error while reading from the connection.

Suggested fix: Ensure that the remote peer maintains the connection until all necessary data is transmitted. Implement proper error handling and reconnection logic to handle unexpected disconnections.

2. Error reading from connection:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.7697114Z logger.go:146: 2025-02-25T10:50:58.772Z	WARN	oracle_streams_1.SingletonPeerWrapper	ragep2p/ragep2p.go:1263	Error reading from connection	{"version": "unset@unset", "remoteAddr": "127.0.0.1:17505", "error": "read tcp 127.0.0.1:42598->127.0.0.1:17505: use of closed network connection", "id": "ragep2p", "peerID": "12D3KooWJMcGgCvPz2Vyo2u5MQmhRmAqqT4iqjU4RtpLtbzobWEd", "remotePeerID": "12D3KooWRcx3XVKoD9TNHopjESqfRV2HWadYehKEsRibXSwwTrRv", "direction": "out"}
**Why**: This error occurs because the network connection was closed while an attempt was made to read from it, indicating that the connection was not properly maintained.

Suggested fix: Ensure that the network connection remains open until all necessary data is read. Implement error handling and reconnection logic to manage closed connections gracefully.

3. Error reading from connection:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.7757418Z logger.go:146: 2025-02-25T10:50:58.772Z	WARN	oracle_streams_1.SingletonPeerWrapper	ragep2p/ragep2p.go:1263	Error reading from connection	{"version": "unset@unset", "id": "ragep2p", "remoteAddr": "127.0.0.1:44304", "error": "read tcp 127.0.0.1:17506->127.0.0.1:44304: use of closed network connection", "direction": "in", "peerID": "12D3KooWJMcGgCvPz2Vyo2u5MQmhRmAqqT4iqjU4RtpLtbzobWEd", "remotePeerID": "12D3KooWALTPZuS3dxgrsmnTEcj2f6x9d6TiDwWHSquMLMy9H8m1"}
**Why**: Similar to the previous errors, this indicates that the network connection was closed unexpectedly, causing an error while attempting to read from it.

Suggested fix: Implement robust error handling and reconnection strategies to ensure that the connection remains open until all necessary data is read. Ensure that both peers maintain the connection properly.

4. Exiting Host.listenLoop due to error while Accepting:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.7830451Z logger.go:146: 2025-02-25T10:50:58.774Z	INFO	oracle_streams_1.SingletonPeerWrapper	ragep2p/ragep2p.go:674	Exiting Host.listenLoop due to error while Accepting	{"version": "unset@unset", "id": "ragep2p", "peerID": "12D3KooWJMcGgCvPz2Vyo2u5MQmhRmAqqT4iqjU4RtpLtbzobWEd", "error": "accept tcp 127.0.0.1:17506: use of closed network connection"}
**Why**: This error indicates that the host's listen loop exited because it encountered an error while accepting a new connection. The network connection was closed unexpectedly.

Suggested fix: Ensure that the network connection remains open and properly managed. Implement error handling to gracefully handle connection closures and attempt reconnections if necessary.

5. Exiting Host.listenLoop due to error while Accepting:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.8257143Z logger.go:146: 2025-02-25T10:50:58.833Z	INFO	oracle_streams_0.SingletonPeerWrapper	ragep2p/ragep2p.go:674	Exiting Host.listenLoop due to error while Accepting	{"version": "unset@unset", "id": "ragep2p", "peerID": "12D3KooWRcx3XVKoD9TNHopjESqfRV2HWadYehKEsRibXSwwTrRv", "error": "accept tcp 127.0.0.1:17505: use of closed network connection"}
**Why**: Similar to the previous error, this indicates that the host's listen loop exited due to an error while accepting a new connection, caused by a closed network connection.

Suggested fix: Implement robust error handling and reconnection strategies to ensure that the network connection remains open and properly managed. Ensure that the host can handle unexpected connection closures gracefully.

6. Exiting Host.listenLoop due to error while Accepting:go_core_tests

Source of Error:
Run tests	2025-02-25T10:52:43.8394359Z logger.go:146: 2025-02-25T10:50:58.894Z	INFO	bootstrap_llo.SingletonPeerWrapper	ragep2p/ragep2p.go:674	Exiting Host.listenLoop due to error while Accepting	{"version": "unset@unset", "peerID": "12D3KooWALTPZuS3dxgrsmnTEcj2f6x9d6TiDwWHSquMLMy9H8m1", "id": "ragep2p", "error": "accept tcp 127.0.0.1:17504: use of closed network connection"}
**Why**: This error indicates that the host's listen loop exited because it encountered an error while accepting a new connection. The network connection was closed unexpectedly.

Suggested fix: Ensure that the network connection remains open and properly managed. Implement error handling to gracefully handle connection closures and attempt reconnections if necessary.

@asoliman92 asoliman92 closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant