-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce MessageProfiles to v1.6 load tests [CCIP-5143] #16556
base: develop
Are you sure you want to change the base?
Conversation
Add MessageDetails param to enable different message types
Also set the gasLimit based on the MessageDetails
AER Report: CI Coreaer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , GolangCI Lint (system-tests/lib) , test-scripts , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests/load) , GolangCI Lint (system-tests/tests) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan 1. GolangCI Lint job failed: lintSource of Error:
Why: The lint job failed because at least one 'GolangCI Lint' matrix job encountered an error. Suggested fix: Investigate the specific GolangCI Lint job that failed to identify and resolve the underlying issues. 2. GolangCI Lint failed to load package: Golang Lint (integration-tests/load)Source of Error:
Why: The linter failed because it could not load export data for the specified package, indicating a possible issue with the package or its dependencies. Suggested fix: Ensure that the package 3. Missing lint report file: Golang Lint (integration-tests/load)Source of Error:
Why: The lint report file Suggested fix: Resolve the linter issues so that the report file can be generated successfully. AER Report: Operator UI CI ran successfully ✅ |
// Set the gas limit for this tx | ||
if gasLimit != 0 { | ||
acc.GasLimit = uint64(gasLimit) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to reset this in case a message profile wants to use default gas limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's zero then it's gonna use the default
@@ -1721,20 +1721,20 @@ func DefaultFeeQuoterDestChainConfig(configEnabled bool, destChainSelector ...ui | |||
return fee_quoter.FeeQuoterDestChainConfig{ | |||
IsEnabled: configEnabled, | |||
MaxNumberOfTokensPerMsg: 10, | |||
MaxDataBytes: 256, | |||
MaxDataBytes: 30_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from 1.5 mainnet values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need someone from onchain team to double check these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very concerning that this is the first time we noticed invalid values inthe changeset which were used for deployments on staging, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I already had the green light from @RensR about these numbers. We didn't catch in staging because we don't send bigger messages
* use workflow key instead of evm config key as encryption pub key * update jd version in e2e tests
* Change default Workflow Execution Rate Limits to PerSender 200 * Regen docs
* wip: support single eth key secret * import p2p key * support multiple eth keys * fix eth keys plumbing and add test * rename vars * working locally * cleanup * address feedback * linter
* CCIP-4796 ccip analyze mcms proposal * mcms analyze * integrate into deployer group * review fixes * review fixes
) * ReportCodec verification of channel definitions * Bump go to 1.24 * remove obsolete cluster profile * Fix mockery * Fix tests --------- Co-authored-by: skudasov <[email protected]>
* add timelock to remote chain * lint * re-add transfer * move to mcms helper * fix buffer bug * mcms validation * set authority * refactor * try to unify ci and local * lint * add update dest configs * add disable * cleanup * error message * v2 * fix test * add mcms to billing * refactor into helper * lint * test without mcms
* Minor * Minor
* bump CTF to Go 1.24 commit * use old Seth version * re-trigger * update again
…posalFromBatches() for solana chain metadata (#16528) * feat: update mcms lib with new timelock converter and update BuildProposalFromBatchesV2() to accept env for extracting solana metadata. * feat: update go mod to new mcms and ccip-solana version * feat: update go mod to new mcms and ccip-solana version * fix: go mod * fix: go mod * fix: go mod core scripts * chore: add changeset * fix: update tx field name to RawData * fix: more cleanup - update tests - go mod tidy - delete comments - other bug fixes * fix: break dep cycle for state package, stop relying on proposalutils package so the `buildProposalMetadataV2` can call `MaybeLoadMCMSWithTimelockChainStateSolana` * fix: merge conflicts develop * fix: go sum * fix: update lib * fix: upgrade ccip solana * fix: downgrade ccip solana for rest of core packages and chainlink/deployment * fix: go mod core scripts add replace * fix: downgrade solana from mcms lib * fix: merge conflicts develop * fix: merge conflicts develop * fix: go mod deps * fix: params in solana utils --------- Co-authored-by: Graham Goh <[email protected]>
* .github: fix integration in memory tests workflow * fix
|
Introduce MessageProfiles to load tests