Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: goreleaser workflow maintanence #16551

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore: goreleaser workflow maintanence #16551

merged 1 commit into from
Feb 25, 2025

Conversation

erikburt
Copy link
Collaborator

@erikburt erikburt commented Feb 24, 2025 •
edited
Loading

Changes

  • Update docker/setup-qemu-action, docker/setup-buildx-action
  • Unpin buildkit version from setup-buildx-action as problem is resolved
  • Add concurrency to workflow
    • This is to help if a label is added while the workflow is already running, it will cancel the in-progress one and start the publish one.
    • The concurrency key is formatted so it will not affect image builds/publishes on subsequent pushes to develop

Testing

Did some testing in #16547.

Also on this PR:

RE-3516

@erikburt erikburt self-assigned this Feb 24, 2025
@erikburt erikburt added the build-publish Build and Publish image to SDLC label Feb 24, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@erikburt erikburt marked this pull request as ready for review February 24, 2025 19:52
@erikburt erikburt requested review from a team as code owners February 24, 2025 19:52
chainchad
chainchad reviewed Feb 24, 2025
View reviewed changes
.github/workflows/build-publish-develop-pr.yml
Comment on lines +26 to +28
concurrency:
group: "build-publish-${{ github.ref_name }}-${{ github.sha }}"
cancel-in-progress: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@erikburt erikburt added this pull request to the merge queue Feb 25, 2025
Merged via the queue into develop with commit 37d65f7 Feb 25, 2025
93 of 96 checks passed
@erikburt erikburt deleted the chore/go-releaser-workflow-maintanance branch February 25, 2025 00:48
krehermann pushed a commit that referenced this pull request Feb 27, 2025
@erikburt @krehermann
chore: goreleaser workflow maintanence (#16551)
704ed0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gheorghestrimtu gheorghestrimtu gheorghestrimtu approved these changes

@chainchad chainchad chainchad approved these changes

Assignees

@erikburt erikburt

Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikburt @gheorghestrimtu @chainchad