chore(deployments/data-streams): adds don related label to node registration #16534
Conversation
giogam
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
giogam
changed the title
|
| labels = append(labels, &ptypes.Label{ | ||
| Key: "nodeType", | ||
| Value: &ntStr, | ||
| }) | ||
|
|
||
| labels = append(labels, &ptypes.Label{ | ||
| Key: fmt.Sprintf("don-%d-%s", donID, donName), |
There was a problem hiding this comment.
This key feels off. Isn't that a value that we should assign to a key?
There was a problem hiding this comment.
Yeah, alternatively, we could use a don key and assign fmt.Sprintf("don-%d-%s", donID, donName) as its value. However, this approach would limit us to a single value per key. For instance, if you wanted to label a node with two DONs, there wouldn’t be a way to attach multiple values to the same key.
There was a problem hiding this comment.
Oh, I see, so this is a "presence marker", i.e. a boolean flag. Sure, works for me.
There was a problem hiding this comment.
I suppose whether this is a limitation for data-streams depends on how the product is operated, but it might still be a good idea to future-proof the implementation regardless.
This PR adds an additional label to indicate the DON a node belongs to, making it easier to retrieve a set of nodes from a specific DON in data-streams changesets.
Requires
Supports