feat(CRE-329): high fidelity offchain job service client #16527
+1,185
−342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you updated files related to
|
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
krehermann
force-pushed
the
cre/in-memory-offchain-client
branch
from
d83729f to
1cef16b
Compare
krehermann
changed the title
krehermann
commented
Feb 26, 2025
| "github.com/smartcontractkit/chainlink-protos/job-distributor/v1/shared/ptypes" | ||
| ) | ||
|
|
||
| func (j JobClient) EnableNode(ctx context.Context, in *nodev1.EnableNodeRequest, opts ...grpc.CallOption) (*nodev1.EnableNodeResponse, error) { |
There was a problem hiding this comment.
this file is just a code move of the node servie API methods
krehermann
commented
Feb 26, 2025
| "github.com/smartcontractkit/chainlink/v2/core/services/job" | ||
| ) | ||
|
|
||
| type JobServiceClient struct { |
There was a problem hiding this comment.
this is the new implementation
krehermann
commented
Feb 26, 2025
|
|
||
| var errNoExist = errors.New("does not exist") | ||
|
|
||
| // proposalStore is an interface for storing job proposals. |
There was a problem hiding this comment.
these store interfaces and implementations are conveniences for the in memory data needed by the JobServiceClient impl. they are not interesting in and of themselves
krehermann
requested review from
EasterTheBunny,
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo,
AnieeG,
jkongie and
vyzaldysanchez
AnieeG
previously approved these changes
Feb 26, 2025
bolekk
previously approved these changes
Feb 26, 2025
| @@ -598,3 +611,54 @@ func (e KeystoreSim) Eth() keystore.Eth { | |||
| func (e KeystoreSim) CSA() keystore.CSA { | |||
| return e.csa | |||
| } | |||
|
|
|||
| func setupJD(t *testing.T, app chainlink.Application) { | |||
There was a problem hiding this comment.
Why are we mixing real code and test helpers here...?
|
vyzaldysanchez
approved these changes
Feb 27, 2025
AnieeG
approved these changes
Feb 27, 2025
Any commits made after this event will not be merged.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRE-329
Implement the JobServiceClient API for in memory integration testing using the real node Feed service APIs
This is a building block to unlock in memory integration tests that have high fidelity to real deployments.
Specifically, it will enable the CRE migration concern jobs to be moved from CLD to this repo and be well tested. That move, then, will enable reuse for CTF & CRIB environment implementations.
Requires
Supports