Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finality level to ExecutedMessages integration tests #16516

Merged
merged 9 commits into from
Feb 25, 2025
Merged

Add finality level to ExecutedMessages integration tests #16516

merged 9 commits into from
Feb 25, 2025

Conversation

0xnogo
Copy link
Collaborator

@0xnogo 0xnogo commented Feb 21, 2025 •
edited
Loading

Bumping cl-ccip to the latest hash + updating ExecutedMessages calls in the ccipreader integ test.

@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@0xnogo 0xnogo marked this pull request as ready for review February 25, 2025 08:31
@0xnogo 0xnogo requested review from a team as code owners February 25, 2025 08:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

@0xnogo 0xnogo enabled auto-merge February 25, 2025 08:54
@0xnogo 0xnogo added this pull request to the merge queue Feb 25, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Merged via the queue into develop with commit 3b8d0ad Feb 25, 2025
186 of 187 checks passed
@0xnogo 0xnogo deleted the ng/update-ExecutedMessages-test branch February 25, 2025 09:24
krehermann pushed a commit that referenced this pull request Feb 27, 2025
@0xnogo @krehermann
Add finality level to ExecutedMessages integration tests (#16516)
8514084 
* add finality level to ExecutedMessages

* bump

* bump cl-ccip

* merge

* bump

* final cl-ccip commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusz-sekara mateusz-sekara mateusz-sekara approved these changes

@0xAustinWang 0xAustinWang 0xAustinWang approved these changes

@chudilka1 chudilka1 Awaiting requested review from chudilka1 chudilka1 is a code owner automatically assigned from smartcontractkit/foundations

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnogo @mateusz-sekara @0xAustinWang