Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding + mcms #16512

Closed
wants to merge 2 commits into from
Closed

padding + mcms #16512

wants to merge 2 commits into from

Conversation

tt-cll
Copy link
Contributor

@tt-cll tt-cll commented Feb 21, 2025

Requires

Supports

Copy link
Contributor

github-actions bot commented Feb 21, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , GolangCI Lint (deployment) , lint , SonarQube Scan

1. File is not goimports-ed with -local github.com/smartcontractkit/chainlink:[Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-02-21T17:20:25.5199075Z deployment/ccip/changeset/solana/cs_deploy_chain.go:909: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint (deployment)	2025-02-21T17:20:25.5200595Z 	data = binary.LittleEndian.AppendUint32(data, uint32(extraBytes + 1024)) // add some padding

Why: The file cs_deploy_chain.go is not formatted according to the goimports tool with the -local flag set to github.com/smartcontractkit/chainlink. This means the imports are not organized as expected.

Suggested fix: Run goimports with the -local github.com/smartcontractkit/chainlink flag on the file to format it correctly.

2. Transaction simulation failed: Error processing Instruction 0: Program failed to complete:[Core Tests (go_core_ccip_deployment_tests)]

Source of Error:
Run tests	2025-02-21T17:28:03.1048432Z 	 	unable to call execute operation instruction: unable to send instruction: (*jsonrpc.RPCError)(0xc0256341e0)({
Run tests	2025-02-21T17:28:03.1048730Z 	 	 Code: (int) -32002,
Run tests	2025-02-21T17:28:03.1049804Z 	 	 Message: (string) (len=89) "Transaction simulation failed: Error processing Instruction 0: Program failed to complete",
Run tests	2025-02-21T17:28:03.1050219Z 	 	 Data: (map[string]interface {}) (len=7) {
Run tests	2025-02-21T17:28:03.1050710Z 	 	 (string) (len=8) "accounts": (interface {}) <nil>,
Run tests	2025-02-21T17:28:03.1051268Z 	 	 (string) (len=3) "err": (map[string]interface {}) (len=1) {
Run tests	2025-02-21T17:28:03.1051943Z 	 	 (string) (len=16) "InstructionError": ([]interface {}) (len=2 cap=2) {
Run tests	2025-02-21T17:28:03.1052304Z 	 	 (json.Number) (len=1) "0",
Run tests	2025-02-21T17:28:03.1052798Z 	 	 (string) (len=23) "ProgramFailedToComplete"
Run tests	2025-02-21T17:28:03.1052965Z 	 	 }
Run tests	2025-02-21T17:28:03.1053124Z 	 	 },
Run tests	2025-02-21T17:28:03.1053698Z 	 	 (string) (len=17) "innerInstructions": (interface {}) <nil>,
Run tests	2025-02-21T17:28:03.1054443Z 	 	 (string) (len=4) "logs": ([]interface {}) (len=4 cap=4) {
Run tests	2025-02-21T17:28:03.1055268Z 	 	 (string) (len=62) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn invoke [1]",
Run tests	2025-02-21T17:28:03.1055854Z 	 	 (string) (len=38) "Program log: Instruction: ExecuteBatch",
Run tests	2025-02-21T17:28:03.1056936Z 	 	 (string) (len=90) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn consumed 28716 of 200000 compute units",
Run tests	2025-02-21T17:28:03.1058565Z 	 	 (string) (len=147) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn failed: Program BPFLoaderUpgradeab1e11111111111111111111111 not supported by inner instructions"
Run tests	2025-02-21T17:28:03.1058728Z 	 	 },
Run tests	2025-02-21T17:28:03.1059322Z 	 	 (string) (len=20) "replacementBlockhash": (interface {}) <nil>,
Run tests	2025-02-21T17:28:03.1059837Z 	 	 (string) (len=10) "returnData": (interface {}) <nil>,
Run tests	2025-02-21T17:28:03.1060438Z 	 	 (string) (len=13) "unitsConsumed": (json.Number) (len=5) "28716"
Run tests	2025-02-21T17:28:03.1060590Z 	 	 }
Run tests	2025-02-21T17:28:03.1060734Z 	 	})

Why: The transaction simulation failed because the program did not complete successfully. The error indicates that the program consumed compute units but failed due to an unsupported instruction by the inner instructions.

Suggested fix: Investigate the specific instruction causing the failure and ensure that all required instructions are supported and correctly implemented. Check the program logic and the environment setup for any discrepancies.

3. Execution reverted: RBACTimelock: underlying transaction reverted:[Core Tests (go_core_ccip_deployment_tests)]

Source of Error:
Run tests	2025-02-21T17:28:03.1345343Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:28:03.1345859Z 	Test: 	TestAddNodes/with_mcms/error_-_unregistered_nop
Run tests	2025-02-21T17:28:03.1370743Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:28:03.1371241Z 	Test: 	TestAddNodes/with_mcms/error_-_unregistered_capability
Run tests	2025-02-21T17:28:03.1452441Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:28:03.1452895Z 	Test: 	TestAddNodes/with_mcms/error_-_deduplicate_signer

Why: The transaction was reverted by the RBACTimelock contract, indicating that the underlying transaction failed. This could be due to various reasons such as invalid parameters, insufficient permissions, or contract logic errors.

Suggested fix: Review the parameters and logic used in the transaction. Ensure that all required permissions are granted and that the contract logic is correct. Debug the specific transaction to identify the root cause of the failure.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@tt-cll tt-cll closed this Feb 21, 2025
@tt-cll tt-cll deleted the tt/paddingMcms branch February 21, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant