Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding + no mcms #16510

Closed
wants to merge 2 commits into from
Closed

padding + no mcms #16510

wants to merge 2 commits into from

Conversation

tt-cll
Copy link
Contributor

@tt-cll tt-cll commented Feb 21, 2025

Requires

Supports

Copy link
Contributor

github-actions bot commented Feb 21, 2025

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Core Tests (go_core_tests) , test-scripts , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , GolangCI Lint (deployment) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. File is not goimports-ed with -local github.com/smartcontractkit/chainlink:[Golang Lint (deployment)]

Source of Error:
Golang Lint (deployment)	2025-02-21T17:21:26.4786722Z deployment/ccip/changeset/solana/cs_deploy_chain.go:918: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint (deployment)	2025-02-21T17:21:26.4788383Z 	data = binary.LittleEndian.AppendUint32(data, uint32(extraBytes + 1024)) // add some padding

Why: The file cs_deploy_chain.go is not formatted according to the goimports tool with the -local flag set to github.com/smartcontractkit/chainlink.

Suggested fix: Run goimports -local github.com/smartcontractkit/chainlink -w deployment/ccip/changeset/solana/cs_deploy_chain.go to format the file correctly.

2. Transaction simulation failed: missing required signature for instruction:[Core Tests (go_core_ccip_deployment_tests)]

Source of Error:
Run tests	2025-02-21T17:30:19.1115287Z 	 	unable to call execute operation instruction: unable to send instruction: (*jsonrpc.RPCError)(0xc01644fad0)({
Run tests	2025-02-21T17:30:19.1115583Z 	 	 Code: (int) -32002,
Run tests	2025-02-21T17:30:19.1116836Z 	 	 Message: (string) (len=105) "Transaction simulation failed: Error processing Instruction 0: missing required signature for instruction",
Run tests	2025-02-21T17:30:19.1117269Z 	 	 Data: (map[string]interface {}) (len=7) {
Run tests	2025-02-21T17:30:19.1117786Z 	 	 (string) (len=8) "accounts": (interface {}) <nil>,
Run tests	2025-02-21T17:30:19.1118360Z 	 	 (string) (len=3) "err": (map[string]interface {}) (len=1) {
Run tests	2025-02-21T17:30:19.1119059Z 	 	 (string) (len=16) "InstructionError": ([]interface {}) (len=2 cap=2) {
Run tests	2025-02-21T17:30:19.1119429Z 	 	 (json.Number) (len=1) "0",
Run tests	2025-02-21T17:30:19.1119931Z 	 	 (string) (len=24) "MissingRequiredSignature"
Run tests	2025-02-21T17:30:19.1120243Z 	 	 }
Run tests	2025-02-21T17:30:19.1120408Z 	 	 },
Run tests	2025-02-21T17:30:19.1120995Z 	 	 (string) (len=17) "innerInstructions": (interface {}) <nil>,
Run tests	2025-02-21T17:30:19.1121571Z 	 	 (string) (len=4) "logs": ([]interface {}) (len=7 cap=8) {
Run tests	2025-02-21T17:30:19.1122421Z 	 	 (string) (len=62) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn invoke [1]",
Run tests	2025-02-21T17:30:19.1123032Z 	 	 (string) (len=38) "Program log: Instruction: ExecuteBatch",
Run tests	2025-02-21T17:30:19.1123845Z 	 	 (string) (len=62) "Program BPFLoaderUpgradeab1e11111111111111111111111 invoke [2]",
Run tests	2025-02-21T17:30:19.1124385Z 	 	 (string) (len=30) "Upgrade authority did not sign",
Run tests	2025-02-21T17:30:19.1125598Z 	 	 (string) (len=102) "Program BPFLoaderUpgradeab1e11111111111111111111111 failed: missing required signature for instruction",
Run tests	2025-02-21T17:30:19.1126711Z 	 	 (string) (len=90) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn consumed 32147 of 200000 compute units",
Run tests	2025-02-21T17:30:19.1127936Z 	 	 (string) (len=102) "Program LoCoNsJFuhTkSQjfdDfn3yuwqhSYoPujmviRHVCzsqn failed: missing required signature for instruction"
Run tests	2025-02-21T17:30:19.1128217Z 	 	 },
Run tests	2025-02-21T17:30:19.1128839Z 	 	 (string) (len=20) "replacementBlockhash": (interface {}) <nil>,
Run tests	2025-02-21T17:30:19.1129363Z 	 	 (string) (len=10) "returnData": (interface {}) <nil>,
Run tests	2025-02-21T17:30:19.1129983Z 	 	 (string) (len=13) "unitsConsumed": (json.Number) (len=5) "32147"
Run tests	2025-02-21T17:30:19.1130134Z 	 	 }
Run tests	2025-02-21T17:30:19.1130283Z 	 	})

Why: The transaction simulation failed because a required signature for an instruction was missing. This indicates that the transaction did not have all the necessary authorizations.

Suggested fix: Ensure that all required signers are included in the transaction. Verify that the upgrade authority and any other necessary accounts have signed the transaction.

3. Execution reverted: RBACTimelock: underlying transaction reverted:[Core Tests (go_core_ccip_deployment_tests)]

Source of Error:
Run tests	2025-02-21T17:30:19.1419294Z 	Error: 	Received unexpected error:
Run tests	2025-02-21T17:30:19.1420083Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:30:19.1420553Z 	Test: 	TestAddNodes/with_mcms/error_-_unregistered_nop
Run tests	2025-02-21T17:30:19.1445291Z 	Error: 	Received unexpected error:
Run tests	2025-02-21T17:30:19.1446083Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:30:19.1446598Z 	Test: 	TestAddNodes/with_mcms/error_-_unregistered_capability
Run tests	2025-02-21T17:30:19.1535420Z 	Error: 	Received unexpected error:
Run tests	2025-02-21T17:30:19.1536406Z 	 	execution reverted: RBACTimelock: underlying transaction reverted
Run tests	2025-02-21T17:30:19.1536893Z 	Test: 	TestAddNodes/with_mcms/error_-_deduplicate_signer

Why: The RBACTimelock contract's underlying transaction reverted, which could be due to various reasons such as incorrect parameters, insufficient permissions, or contract logic errors.

Suggested fix: Investigate the specific conditions under which the RBACTimelock transaction is reverting. Ensure that all parameters are correct and that the contract logic is functioning as expected. Verify that the necessary permissions and roles are correctly assigned.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@tt-cll tt-cll closed this Feb 21, 2025
@tt-cll tt-cll deleted the tt/workingRaw branch February 21, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant